diff options
| author | Andrew Chow <github@achow101.com> | 2023-10-05 15:29:24 -0400 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-10-05 15:35:54 -0400 |
| commit | cf553e3ab7b3827c9c1b91fcc50082856f761913 (patch) | |
| tree | f407ae9a63c96d2a094ca10b08d2c9cfff717a53 /test | |
| parent | 0b2c93bc560cfb0f6cbf2151bb033d67f2648891 (diff) | |
| parent | fa071aeb61dcc42cd122d3fb1abe4b9c238f8010 (diff) | |
| download | bitcoin-cf553e3ab7b3827c9c1b91fcc50082856f761913.tar.xz | |
Merge bitcoin/bitcoin#28597: wallet: No BDB creation, unless -deprecatedrpc=create_bdb
fa071aeb61dcc42cd122d3fb1abe4b9c238f8010 wallet: No BDB creation, unless -deprecatedrpc=create_bdb (MarcoFalke)
Pull request description:
With BDB being removed soon, it seems confusing and harmful to allow users to create fresh BDB wallets going forward, as it would load them with an additional burden of having to migrate them soon after.
Also, it would be good to allow for one release for test (and external) scripts to adapt.
Fix all issues by introducing the `-deprecatedrpc=create_bdb` setting.
ACKs for top commit:
Sjors:
tACK fa071aeb61dcc42cd122d3fb1abe4b9c238f8010
achow101:
ACK fa071aeb61dcc42cd122d3fb1abe4b9c238f8010
furszy:
utACK fa071aeb
Tree-SHA512: 37a4c3e4ba659e0ebe2382e71d9c80e42a895d9ad743f5dda7c110fbbb7d2a36f46769982552a9ac0c3a57203379ef164be97aa8033eb7674d6b4da030ba8f9b
Diffstat (limited to 'test')
| -rw-r--r-- | test/functional/test_framework/util.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/test/functional/test_framework/util.py b/test/functional/test_framework/util.py index 9143397042..3bd18c26d8 100644 --- a/test/functional/test_framework/util.py +++ b/test/functional/test_framework/util.py @@ -404,6 +404,7 @@ def write_config(config_path, *, n, chain, extra_config="", disable_autoconnect= f.write("upnp=0\n") f.write("natpmp=0\n") f.write("shrinkdebugfile=0\n") + f.write("deprecatedrpc=create_bdb\n") # Required to run the tests # To improve SQLite wallet performance so that the tests don't timeout, use -unsafesqlitesync f.write("unsafesqlitesync=1\n") if disable_autoconnect: |