diff options
| author | fanquake <fanquake@gmail.com> | 2023-09-21 15:50:08 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-09-21 15:50:15 +0000 |
| commit | cf0711cac329faa3122b704ce382a0e695d968a7 (patch) | |
| tree | 4586c0d882702f3942955560bd3cf06b0748bd69 /test | |
| parent | 41cb17fdb656c806e54a8410c7f24c78278d9e6f (diff) | |
| parent | d05be124dbc0b24fb69d0c28ba2d6b297d243751 (diff) | |
| download | bitcoin-cf0711cac329faa3122b704ce382a0e695d968a7.tar.xz | |
Merge bitcoin/bitcoin#27934: test: added coverage to estimatefee
d05be124dbc0b24fb69d0c28ba2d6b297d243751 test: added coverage to estimatefee (kevkevin)
Pull request description:
Added a assert for an rpc error when we try to estimate fee for the max conf_target
Line I am adding coverage to https://github.com/bitcoin/bitcoin/blob/master/src/rpc/fees.cpp#LL71C52-L71C52
ACKs for top commit:
MarcoFalke:
lgtm ACK d05be124dbc0b24fb69d0c28ba2d6b297d243751
Tree-SHA512: dfab075989446e33d1a5ff1a308f1ba1b9f80cce3848fbe4231f69212ceef456a3f2b19365a42123e0397c31893fd9f1fd9973cc00cfbb324386e12ed0e6bccc
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/rpc_estimatefee.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/test/functional/rpc_estimatefee.py b/test/functional/rpc_estimatefee.py index dad3cbcf0c..6643799a76 100755 --- a/test/functional/rpc_estimatefee.py +++ b/test/functional/rpc_estimatefee.py @@ -36,6 +36,9 @@ class EstimateFeeTest(BitcoinTestFramework): assert_raises_rpc_error(-1, "estimatesmartfee", self.nodes[0].estimatesmartfee, 1, 'ECONOMICAL', 1) assert_raises_rpc_error(-1, "estimaterawfee", self.nodes[0].estimaterawfee, 1, 1, 1) + # max value of 1008 per src/policy/fees.h + assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008", self.nodes[0].estimaterawfee, 1009) + # valid calls self.nodes[0].estimatesmartfee(1) # self.nodes[0].estimatesmartfee(1, None) |