diff options
| author | Andrew Chow <achow101-github@achow101.com> | 2021-09-10 20:24:44 -0400 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2022-02-15 09:22:06 +0000 |
| commit | bd7e08e36bf2e1238ddf8cc01433f8db82f848c9 (patch) | |
| tree | 73ec009a39a25062b7bff8c09faa44bdd5a7f7b8 /test | |
| parent | 227ae652542451834faddbaffb54fc384e9156e6 (diff) | |
fees: Always round up fee calculated from a feerate
When calculating the fee for a given tx size from a fee rate, we should
always round up to the next satoshi. Otherwise, if we round down (via
truncation), the calculated fee may result in a fee with a feerate
slightly less than targeted.
This is particularly important for coin selection as a slightly lower
feerate than expected can result in a variety of issues.
Github-Pull: #22949
Rebased-From: 0fbaef9676a1dcb84bcf95afd8d994831ab327b6
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/wallet_keypool.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/wallet_keypool.py b/test/functional/wallet_keypool.py index 28bfc9116f..9286387f96 100755 --- a/test/functional/wallet_keypool.py +++ b/test/functional/wallet_keypool.py @@ -179,7 +179,7 @@ class KeyPoolTest(BitcoinTestFramework): assert_equal("psbt" in res, True) # create a transaction without change at the maximum fee rate, such that the output is still spendable: - res = w2.walletcreatefundedpsbt(inputs=[], outputs=[{destination: 0.00010000}], options={"subtractFeeFromOutputs": [0], "feeRate": 0.0008824}) + res = w2.walletcreatefundedpsbt(inputs=[], outputs=[{destination: 0.00010000}], options={"subtractFeeFromOutputs": [0], "feeRate": 0.0008823}) assert_equal("psbt" in res, True) assert_equal(res["fee"], Decimal("0.00009706")) |