diff options
| author | fanquake <fanquake@gmail.com> | 2022-07-05 11:40:52 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2022-07-05 11:52:52 +0100 |
| commit | 9fb2a2bc6768ab03fcada9155d52a16ce6f6a0cc (patch) | |
| tree | e91d318fa335d823e59c3b2faac542ae02bd4995 /test | |
| parent | 87d012324afa285221073540781295f1b7381a15 (diff) | |
| parent | cccf691c24f9cbc4aedd1b36c1d9ba173910ceca (diff) | |
| download | bitcoin-9fb2a2bc6768ab03fcada9155d52a16ce6f6a0cc.tar.xz | |
Merge bitcoin/bitcoin#25536: contrib: dedup `get_witness_script` helper in signet miner
cccf691c24f9cbc4aedd1b36c1d9ba173910ceca contrib: dedup `get_witness_script` helper in signet miner (Sebastian Falbesoner)
Pull request description:
The helper `get_witness_script` is already available in the `blocktools` module of our test framework, i.e. there is no need to re-implement it in the signet miner script. Note that the cast from CScript to bytes is necessary for applying the `+=` operator on the scriptPubKey later, which would fail for CScript:
```
File "/home/honeybadger/bitcoin/contrib/signet/miner", line 132, in signet_txs
txs[0].vout[-1].scriptPubKey += CScriptOp.encode_op_pushdata(SIGNET_HEADER)
File "/home/honeybadger/bitcoin/test/functional/test_framework/script.py", line 460, in __add__
raise NotImplementedError
NotImplementedError
```
ACKs for top commit:
kallewoof:
ACK cccf691c24f9cbc4aedd1b36c1d9ba173910ceca
Tree-SHA512: 5965a9f27626e3dd2769a0436263fb646e9d4b67071505122c017f7b0050250e83f524135e57093870b8c64894d64762a51d2c3c68d52dd1e545f23d4734fecb
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions