diff options
| author | fanquake <fanquake@gmail.com> | 2019-09-02 15:36:57 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2019-09-02 16:17:11 +0800 |
| commit | 6519be605480fec95dcd814771038efcb1ad2abe (patch) | |
| tree | 9ce5f837a063c7f43992b68fff33de578fb91b7c /test | |
| parent | 7d6f63cc2c2b9c4f07a43619eef0b7314474fffd (diff) | |
| parent | 9b92538adebd30353ffc1a427bc20ab0c3fc75f1 (diff) | |
Merge #13868: Remove unused fScriptChecks parameter from CheckInputs
9b92538adebd30353ffc1a427bc20ab0c3fc75f1 Remove unused fScriptChecks parameter from CheckInputs (Matt Corallo)
Pull request description:
fScriptChecks = false just short-circuits the entire function, so
passing it in is entirely useless.
This is extracted from #13233 /cc TheBlueMatt.
Recommend reviewing with `git show --ignore-all-space`, i.e.:
https://github.com/bitcoin/bitcoin/pull/13868/files?w=1
ACKs for top commit:
TheBlueMatt:
utACK 9b92538adebd30353ffc1a427bc20ab0c3fc75f1. Checked diff had no functional change and new comment copy looks correct.
kallewoof:
ACK 9b92538adebd30353ffc1a427bc20ab0c3fc75f1
ajtowns:
ACK 9b92538adebd30353ffc1a427bc20ab0c3fc75f1 ; code review, checked tests work. Looks right to me, and fanquake's notes make sense. Could change the coinbase early exit to `assert(!tx.IsCoinBase());`.
fanquake:
ACK 9b92538adebd30353ffc1a427bc20ab0c3fc75f1 - Notes / testing below.
Tree-SHA512: add253a3e8cf4b33eddbc49efcec333c14b5ea61c7d34e43230351d40cff6adc919a75b91c72c4de8647a395284db74a61639f4c67848d4b2fec3a705b557790
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions