diff options
| author | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2022-12-20 20:11:10 +0000 |
|---|---|---|
| committer | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2022-12-20 20:13:12 +0000 |
| commit | 497f26552b36a113f9312da557ad4b58e149524d (patch) | |
| tree | 9f38e90cab4acf2b491dac2f531fe49d45b55847 /test | |
| parent | dcdfd72861c09a7945b9facc3726177a2d06fa64 (diff) | |
| parent | 1b228497fa729c512a15bdfa80f61a610abfe8a5 (diff) | |
| download | bitcoin-497f26552b36a113f9312da557ad4b58e149524d.tar.xz | |
Merge bitcoin-core/gui#605: Delete splash screen widget early
1b228497fa729c512a15bdfa80f61a610abfe8a5 qt: Drop no longer used `SplashScreen::finish()` slot (Hennadii Stepanov)
10811afff40efed1fda7eecab89884eaadd7146c qt: Drop no longer used `BitcoinApplication::splashFinished()` signal (Hennadii Stepanov)
5299cfe371ddad806b1c4538d17cde069e25b1c1 qt: Delete splash screen widget explicitly (Hennadii Stepanov)
Pull request description:
Fixes bitcoin-core/gui#604.
Fixes bitcoin/bitcoin#25146.
Fixes bitcoin/bitcoin#26340.
`SplashScreen::deleteLater()` [does not guarantee](https://doc.qt.io/qt-5/qobject.html#deleteLater) deletion of the `m_splash` object prior to the wallet context deletion. If the latter happens first, the [segfault](https://github.com/bitcoin-core/gui/issues/604#issuecomment-1133907013) follows.
ACKs for top commit:
dooglus:
ACK https://github.com/bitcoin-core/gui/commit/1b228497fa729c512a15bdfa80f61a610abfe8a5
furszy:
ACK 1b228497
john-moffett:
ACK 1b228497fa729c512a15bdfa80f61a610abfe8a5
Tree-SHA512: bb01d0bf2051f5b184dc415c4f5d32dfb7b8bd772feff7ec7754ded4c6482de27f004b9712df7d53c5ee82e153f48aef4372e4a49d7bcbbb137f73e9b4947962
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions