diff options
| author | Matthew Zipkin <pinheadmz@gmail.com> | 2023-07-07 14:31:18 -0400 |
|---|---|---|
| committer | Matthew Zipkin <pinheadmz@gmail.com> | 2024-05-14 10:32:43 -0400 |
| commit | 2ca1460ae3a7217eaa8c5972515bf622bedadfce (patch) | |
| tree | 5812d18bb8eb28d68d666ae26cc1232cd8f00d3a /test | |
| parent | a64a2b77e09bff784a2635ba19ff4aa6582bb5a5 (diff) | |
| download | bitcoin-2ca1460ae3a7217eaa8c5972515bf622bedadfce.tar.xz | |
rpc: identify JSON-RPC 2.0 requests
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/interface_rpc.py | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/test/functional/interface_rpc.py b/test/functional/interface_rpc.py index 748d83858a..075dd1c2bc 100755 --- a/test/functional/interface_rpc.py +++ b/test/functional/interface_rpc.py @@ -161,8 +161,10 @@ class RPCInterfaceTest(BitcoinTestFramework): self.log.info("Testing nonstandard jsonrpc 1.0 version number is accepted...") self.test_batch_request(lambda idx: BatchOptions(request_fields={"jsonrpc": "1.0"})) - self.log.info("Testing unrecognized jsonrpc version number is accepted...") - self.test_batch_request(lambda idx: BatchOptions(request_fields={"jsonrpc": "2.1"})) + self.log.info("Testing unrecognized jsonrpc version number is rejected...") + self.test_batch_request(lambda idx: BatchOptions( + request_fields={"jsonrpc": "2.1"}, + response_fields={"result": None, "error": {"code": RPC_INVALID_REQUEST, "message": "JSON-RPC version not supported"}})) def test_http_status_codes(self): self.log.info("Testing HTTP status codes for JSON-RPC 1.1 requests...") @@ -188,11 +190,11 @@ class RPCInterfaceTest(BitcoinTestFramework): expect_http_rpc_status(500, RPC_INVALID_PARAMETER, self.nodes[0], "getblockhash", [42], 2, False) # force-send invalidly formatted requests response, status = send_json_rpc(self.nodes[0], {"jsonrpc": 2, "method": "getblockcount"}) - assert_equal(response, {"error": None, "id": None, "result": 0}) - assert_equal(status, 200) + assert_equal(response, {"id": None, "result": None, "error": {"code": RPC_INVALID_REQUEST, "message": "jsonrpc field must be a string"}}) + assert_equal(status, 400) response, status = send_json_rpc(self.nodes[0], {"jsonrpc": "3.0", "method": "getblockcount"}) - assert_equal(response, {"error": None, "id": None, "result": 0}) - assert_equal(status, 200) + assert_equal(response, {"id": None, "result": None, "error": {"code": RPC_INVALID_REQUEST, "message": "JSON-RPC version not supported"}}) + assert_equal(status, 400) self.log.info("Testing HTTP status codes for JSON-RPC 2.0 notifications...") # Not notification: id exists |