diff options
| author | fanquake <fanquake@gmail.com> | 2023-10-16 11:07:26 +0200 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-10-16 11:21:45 +0200 |
| commit | 22fa1f4702e9a60e141f545f8d09704deca34b22 (patch) | |
| tree | a07b71e25c23d349d6310af5c04d0b9ecf7811c3 /test | |
| parent | ab2f531b785c3c17746ac9766a6db5b6d26677e8 (diff) | |
| parent | e6e444c06cbf09380f9924dff3d21c1be15d1753 (diff) | |
| download | bitcoin-22fa1f4702e9a60e141f545f8d09704deca34b22.tar.xz | |
Merge bitcoin/bitcoin#28565: rpc: getaddrmaninfo followups
e6e444c06cbf09380f9924dff3d21c1be15d1753 refactor: add and use EnsureAnyAddrman in rpc (stratospher)
bf589a50a0d6a7b94f1ba1ddf24a1497fd35ad44 doc: add release notes for #27511 (stratospher)
3931e6abc39b8aee1472028dbf76eeb10708d2b4 rpc: `getaddrmaninfo` followups (stratospher)
Pull request description:
- make `getaddrmaninfo` RPC public since it's not for development purposes only and regular users might find it useful. [#26988 (comment)](https://github.com/bitcoin/bitcoin/pull/26988#issuecomment-1738371584)
- add missing `all_networks` key to RPC help. [#27511 (comment)](https://github.com/bitcoin/bitcoin/pull/27511#discussion_r1335084087)
- fix clang format spacing
- add and use `EnsureAddrman` in RPC code. [#27511 (comment)](https://github.com/bitcoin/bitcoin/pull/27511#discussion_r1331501491)
ACKs for top commit:
0xB10C:
Code Review re-ACK e6e444c06cbf09380f9924dff3d21c1be15d1753
theStack:
Code-review ACK e6e444c06cbf09380f9924dff3d21c1be15d1753
pablomartin4btc:
tested ACK e6e444c06cbf09380f9924dff3d21c1be15d1753
Tree-SHA512: c14090d5c64ff15e92d252578de2437bb2ce2e1e431d6698580241a29190f0a3528ae5b013c0ddb76a9ae538507191295c37cab7fd93469941cadbde44587072
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/rpc_net.py | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/test/functional/rpc_net.py b/test/functional/rpc_net.py index 2c7f974d0b..44b86662ea 100755 --- a/test/functional/rpc_net.py +++ b/test/functional/rpc_net.py @@ -371,11 +371,6 @@ class NetTest(BitcoinTestFramework): self.log.info("Test getaddrmaninfo") node = self.nodes[1] - self.log.debug("Test that getaddrmaninfo is a hidden RPC") - # It is hidden from general help, but its detailed help may be called directly. - assert "getaddrmaninfo" not in node.help() - assert "getaddrmaninfo" in node.help("getaddrmaninfo") - # current count of ipv4 addresses in addrman is {'new':1, 'tried':1} self.log.info("Test that count of addresses in addrman match expected values") res = node.getaddrmaninfo() |