diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-12-07 12:48:38 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-12-07 12:48:55 +0100 |
| commit | 00f4dcd5520e14529b5c3fa8e14feb3a023ffb4c (patch) | |
| tree | 2268c29418a37a325246568572801164d0a10738 /test | |
| parent | f3e17686b37a70860bd4636f54c77da6fef59240 (diff) | |
| parent | fa0f4157098ea68169ced44730986d0ed2c3a5aa (diff) | |
| download | bitcoin-00f4dcd5520e14529b5c3fa8e14feb3a023ffb4c.tar.xz | |
Merge #20138: net: Assume that SetCommonVersion is called at most once per peer
fa0f4157098ea68169ced44730986d0ed2c3a5aa net: Assume that SetCommonVersion is called at most once per peer (MarcoFalke)
Pull request description:
This restores the check removed in https://github.com/bitcoin/bitcoin/pull/17785#discussion_r503224381
Instead of using `error`, which was used previously, it uses a newly introduced `Assume()`. `error` had several issues:
* It logs unconditionally to the debug log
* It doesn't abort the program when the error is hit in tests
ACKs for top commit:
practicalswift:
cr ACK fa0f4157098ea68169ced44730986d0ed2c3a5aa: patch looks correct
jnewbery:
utACK fa0f4157098ea68169ced44730986d0ed2c3a5aa
Tree-SHA512: cd7424a9485775e8c7093b725f8f52a90d47485185e79bac80f7810e450d0b3fda608d8805e9239094929f7bad2dca3fe772fb78ae606c2399d15405521e136b
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions