diff options
| author | fanquake <fanquake@gmail.com> | 2023-02-22 09:26:23 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-02-22 09:28:09 +0000 |
| commit | 0c579203d265e4c74a0b1fc33147bf85ef16d56a (patch) | |
| tree | 3b8b23cbc75f929e81a52555c5c05243743651ff /test/util | |
| parent | 80f4979322b574be29c684b2e106804432420ebf (diff) | |
| parent | 61bb4e783b3acc62b121a228f6b14c2462e23315 (diff) | |
| download | bitcoin-0c579203d265e4c74a0b1fc33147bf85ef16d56a.tar.xz | |
Merge bitcoin/bitcoin#25867: lint: enable E722 do not use bare except
61bb4e783b3acc62b121a228f6b14c2462e23315 lint: enable E722 do not use bare except (Leonardo Lazzaro)
Pull request description:
Improve test code and enable E722 lint check.
If you want to catch all exceptions that signal program errors, use except Exception: (bare except is equivalent to except BaseException:).
Reference: https://peps.python.org/pep-0008/#programming-recommendations
ACKs for top commit:
MarcoFalke:
lgtm ACK 61bb4e783b3acc62b121a228f6b14c2462e23315
Tree-SHA512: c7497769d5745fa02c78a20f4a0e555d8d3996d64af6faf1ce28e22ac1d8be415b98e967294679007b7bda2a9fd04031a9d140b24201e00257ceadeb5c5d7665
Diffstat (limited to 'test/util')
| -rwxr-xr-x | test/util/test_runner.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/util/test_runner.py b/test/util/test_runner.py index ea3626fa65..e5cdd0bc3a 100755 --- a/test/util/test_runner.py +++ b/test/util/test_runner.py @@ -54,7 +54,7 @@ def bctester(testDir, input_basename, buildenv): try: bctest(testDir, testObj, buildenv) logging.info("PASSED: " + testObj["description"]) - except: + except Exception: logging.info("FAILED: " + testObj["description"]) failed_testcases.append(testObj["description"]) @@ -96,7 +96,7 @@ def bctest(testDir, testObj, buildenv): try: with open(os.path.join(testDir, outputFn), encoding="utf8") as f: outputData = f.read() - except: + except Exception: logging.error("Output file " + outputFn + " cannot be opened") raise if not outputData: |