diff options
| author | merge-script <32963518+hebasto@users.noreply.github.com> | 2024-05-07 21:31:14 +0100 |
|---|---|---|
| committer | merge-script <32963518+hebasto@users.noreply.github.com> | 2024-05-07 21:31:14 +0100 |
| commit | 4e56df8f915bf6e769920ef12e7c52848786a56d (patch) | |
| tree | 86af1f936bd5cac6babaa388bc15c38ce8b63004 /test/lint | |
| parent | 8efd03ad04726aa34219ad83115a3d45030412c3 (diff) | |
| parent | fb9f150759b22772dd48983a2be1ea397245e289 (diff) | |
| download | bitcoin-4e56df8f915bf6e769920ef12e7c52848786a56d.tar.xz | |
Merge bitcoin-core/gui#819: Fix misleading signmessage error with segwit
fb9f150759b22772dd48983a2be1ea397245e289 gui: fix misleading signmessage error with segwit (willcl-ark)
Pull request description:
As described in https://github.com/bitcoin/bitcoin/issues/10542 (and numerous other places), message signing in Bitcoin Core does not support "signing with a segwit address" and likely will not in the foreseeable future, or at least until a new message-signing standard is agreed upon.
Therefore update the possibly misleading error message presented to the user in the GUI to detail more specifically the reason their message cannot be signed, in the case that a non P2PKH address is entered.
This change takes the [suggested wording](https://github.com/bitcoin/bitcoin/issues/10542#issuecomment-1960313569) from @adiabat.
Perhaps with this we can close https://github.com/bitcoin/bitcoin/issues/10542 ?
ACKs for top commit:
hebasto:
ACK fb9f150759b22772dd48983a2be1ea397245e289.
Tree-SHA512: 5ba8d722ad3632dad2e0a2aa94b0f466b904e7885a247a5d26ebdfce54e3611090b103029d8dfce92adc49e50fe5f4830f687d867b4c56c3ea997e519b4e188d
Diffstat (limited to 'test/lint')
0 files changed, 0 insertions, 0 deletions