diff options
| author | fanquake <fanquake@gmail.com> | 2023-05-29 10:35:14 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-05-29 10:48:53 +0100 |
| commit | a2e111b8a3d17e328eba6111f6c9138543255f3d (patch) | |
| tree | 3c600b7b4863b731d36acd1b8efa14fb45e11bdd /test/functional | |
| parent | b5ed656c3ba5198f58e771cc5f7147e02247a789 (diff) | |
| parent | fa6b11a55663e70369bfbbba5fccc55b33f2b310 (diff) | |
| download | bitcoin-a2e111b8a3d17e328eba6111f6c9138543255f3d.tar.xz | |
Merge bitcoin/bitcoin#27765: test: Throw error when -signetchallenge is non-hex
fa6b11a55663e70369bfbbba5fccc55b33f2b310 test: Throw error when -signetchallenge is non-hex (MarcoFalke)
Pull request description:
Instead of silently parsing non-hex to an empty challenge, throw an error.
Also, add missing includes while touching the file.
ACKs for top commit:
kevkevinpal:
ACK [fa6b11a](https://github.com/bitcoin/bitcoin/pull/27765/commits/fa6b11a55663e70369bfbbba5fccc55b33f2b310)
kallewoof:
ACK fa6b11a
TheCharlatan:
Nice, ACK fa6b11a55663e70369bfbbba5fccc55b33f2b310
Tree-SHA512: 018ebbbf819ba7cdf0c6dd294fdfaa5ddb81b87058a8b9c57b96066d5b07e1656fd78f18e3cef375aebefa191fa515c2c70bc764880fa05f98f526334431a616
Diffstat (limited to 'test/functional')
| -rwxr-xr-x | test/functional/feature_signet.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/test/functional/feature_signet.py b/test/functional/feature_signet.py index b41fe378af..a90a2a8e5e 100755 --- a/test/functional/feature_signet.py +++ b/test/functional/feature_signet.py @@ -76,6 +76,9 @@ class SignetBasicTest(BitcoinTestFramework): self.log.info("test that signet logs the network magic on node start") with self.nodes[0].assert_debug_log(["Signet derived magic (message start)"]): self.restart_node(0) + self.stop_node(0) + self.nodes[0].assert_start_raises_init_error(extra_args=["-signetchallenge=abc"], expected_msg="Error: -signetchallenge must be hex, not 'abc'.") + self.nodes[0].assert_start_raises_init_error(extra_args=["-signetchallenge=abc"] * 2, expected_msg="Error: -signetchallenge cannot be multiple values.") if __name__ == '__main__': |