diff options
author | John Newbery <john@johnnewbery.com> | 2018-04-02 15:40:38 -0400 |
---|---|---|
committer | John Newbery <john@johnnewbery.com> | 2018-04-02 15:40:40 -0400 |
commit | 89fe5feea21d341c09ed46d16680dc3dad11076e (patch) | |
tree | 4626a141b125ebf549ca6204600f72bc39d80cba /test/functional | |
parent | 18815b4bfb20c9c1112e547217662529d81e4393 (diff) | |
download | bitcoin-89fe5feea21d341c09ed46d16680dc3dad11076e.tar.xz |
[tests] Stop feature_block.py from blowing up memory.
The new P2PDataStore class was sending full blocks in headers messages,
which meant that calls to send_blocks_and_test() would blow up memory if
called with a large number of blocks. Fix that by only sending headers
in headers messages.
Diffstat (limited to 'test/functional')
-rwxr-xr-x | test/functional/test_framework/mininode.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/functional/test_framework/mininode.py b/test/functional/test_framework/mininode.py index f1f7d0c0cd..aba2841682 100755 --- a/test/functional/test_framework/mininode.py +++ b/test/functional/test_framework/mininode.py @@ -498,7 +498,7 @@ class P2PDataStore(P2PInterface): # as we go. prev_block_hash = headers_list[-1].hashPrevBlock if prev_block_hash in self.block_store: - prev_block_header = self.block_store[prev_block_hash] + prev_block_header = CBlockHeader(self.block_store[prev_block_hash]) headers_list.append(prev_block_header) if prev_block_header.sha256 == hash_stop: # if this is the hashstop header, stop here @@ -539,7 +539,7 @@ class P2PDataStore(P2PInterface): self.block_store[block.sha256] = block self.last_block_hash = block.sha256 - self.send_message(msg_headers([blocks[-1]])) + self.send_message(msg_headers([CBlockHeader(blocks[-1])])) if request_block: wait_until(lambda: blocks[-1].sha256 in self.getdata_requests, timeout=timeout, lock=mininode_lock) |