aboutsummaryrefslogtreecommitdiff
path: root/test/functional
diff options
context:
space:
mode:
authorglozow <gloriajzhao@gmail.com>2022-09-28 14:31:20 +0100
committerglozow <gloriajzhao@gmail.com>2023-01-10 11:09:03 +0000
commit5eab397b9840de5a4729bea723794b529e5fcbb4 (patch)
tree6a4d084470ab5b1d74fc1d15ed8e4d08e85e341c /test/functional
parent601bac88cb95404e7d38ac6348d959c0e06bd922 (diff)
[validation] remove PackageMempoolAcceptResult::m_package_feerate
This value creates an extremely confusing interface as its existence is dependent upon implementation details (whether something was submitted on its own, etc). MempoolAcceptResult::m_effective_feerate is much more helpful, as it always exists for submitted transactions.
Diffstat (limited to 'test/functional')
-rwxr-xr-xtest/functional/rpc_packages.py12
1 files changed, 0 insertions, 12 deletions
diff --git a/test/functional/rpc_packages.py b/test/functional/rpc_packages.py
index ba782c5bb9..10388399ad 100755
--- a/test/functional/rpc_packages.py
+++ b/test/functional/rpc_packages.py
@@ -321,12 +321,6 @@ class RPCPackagesTest(BitcoinTestFramework):
# submitpackage result should be consistent with testmempoolaccept and getmempoolentry
self.assert_equal_package_results(node, testmempoolaccept_result, submitpackage_result)
- # Package feerate is calculated for the remaining transactions after deduplication and
- # individual submission. If only 0 or 1 transaction is left, e.g. because all transactions
- # had high-feerates or were already in the mempool, no package feerate is provided.
- # In this case, since all of the parents have high fees, each is accepted individually.
- assert "package-feerate" not in submitpackage_result
-
# The node should announce each transaction. No guarantees for propagation.
peer.wait_for_broadcast([tx["tx"].getwtxid() for tx in package_txns])
self.generate(node, 1)
@@ -363,12 +357,6 @@ class RPCPackagesTest(BitcoinTestFramework):
assert_equal([tx_poor["wtxid"], tx_child["tx"].getwtxid()], poor_parent_result["fees"]["effective-includes"])
assert_equal([tx_poor["wtxid"], tx_child["tx"].getwtxid()], child_result["fees"]["effective-includes"])
- # Package feerate is calculated for the remaining transactions after deduplication and
- # individual submission. Since this package had a 0-fee parent, package feerate must have
- # been used and returned.
- assert "package-feerate" in submitpackage_result
- assert_fee_amount(DEFAULT_FEE, rich_parent_result["vsize"] + child_result["vsize"], submitpackage_result["package-feerate"])
-
# The node will broadcast each transaction, still abiding by its peer's fee filter
peer.wait_for_broadcast([tx["tx"].getwtxid() for tx in package_txns])
self.generate(node, 1)