Merge #14023: Remove accounts rpcs

bb08423d5ca866d4a139a3b57ff110d818d08b32 [doc] Add release notes for 'account' API removal (John Newbery)
1f4b865e57b4567270b1586bb1f348ab9106485d [wallet] Re-sort wallet RPC commands (John Newbery)
f0dc850bf698f7377797d7d68365d4fc79b0221c [wallet] Remove wallet account RPCs (John Newbery)
c410f415758913c933ad6c71cf50227cc85aa385 [tests] Remove wallet accounts test (John Newbery)

Pull request description:

  This is the first part of #13825. It simply removes the RPC methods and tests.

  #13825 touches lots of files and will require frequent rebasing.

  Breaking it down for easier reviewing and fewer rebases.

Tree-SHA512: d29af8e7a035e4484e6b9bb56cb86592be0ec112d8ba4ce19c15d15366ff3086e89e99fca26b90c9d66f6d3e06894486d0f29948df0bb7dcb1e2c49c6887a85a

1 files changed, 18 insertions, 108 deletions

diff --git a/test/functional/wallet_labels.py b/test/functional/wallet_labels.py
index 0817054149..01a73d9cef 100755
--- a/test/functional/wallet_labels.py
+++ b/test/functional/wallet_labels.py
@@ -5,15 +5,9 @@
 """Test label RPCs.
 
 RPCs tested are:
-    - getaccountaddress
-    - getaddressesbyaccount/getaddressesbylabel
+    - getaddressesbylabel
     - listaddressgroupings
     - setlabel
-    - sendfrom (with account arguments)
-    - move (with account arguments)
-
-Run the test twice - once using the accounts API and once using the labels API.
-The accounts API test can be removed in V0.18.
 """
 from collections import defaultdict
 
@@ -23,22 +17,11 @@ from test_framework.util import assert_equal, assert_raises_rpc_error
 class WalletLabelsTest(BitcoinTestFramework):
     def set_test_params(self):
         self.setup_clean_chain = True
-        self.num_nodes = 2
-        self.extra_args = [['-deprecatedrpc=accounts'], []]
-
-    def setup_network(self):
-        """Don't connect nodes."""
-        self.setup_nodes()
+        self.num_nodes = 1
 
     def run_test(self):
-        """Run the test twice - once using the accounts API and once using the labels API."""
-        self.log.info("Test accounts API")
-        self._run_subtest(True, self.nodes[0])
-        self.log.info("Test labels API")
-        self._run_subtest(False, self.nodes[1])
-
-    def _run_subtest(self, accounts_api, node):
-        # Check that there's no UTXO on any of the nodes
+        # Check that there's no UTXO on the node
+        node = self.nodes[0]
         assert_equal(len(node.listunspent()), 0)
 
         # Note each time we call generate, all generated coins go into
@@ -61,17 +44,12 @@ class WalletLabelsTest(BitcoinTestFramework):
             linked_addresses.add(address_group[0][0])
 
         # send 50 from each address to a third address not in this wallet
-        # There's some fee that will come back to us when the miner reward
-        # matures.
         common_address = "msf4WtN1YQKXvNtvdFYt9JBnUD2FB41kjr"
-        txid = node.sendmany(
-            fromaccount="",
+        node.sendmany(
             amounts={common_address: 100},
             subtractfeefrom=[common_address],
             minconf=1,
         )
-        tx_details = node.gettransaction(txid)
-        fee = -tx_details['details'][0]['fee']
         # there should be 1 address group, with the previously
         # unlinked addresses now linked (they both have 0 balance)
         address_groups = node.listaddressgroupings()
@@ -85,32 +63,22 @@ class WalletLabelsTest(BitcoinTestFramework):
         # we want to reset so that the "" label has what's expected.
         # otherwise we're off by exactly the fee amount as that's mined
         # and matures in the next 100 blocks
-        if accounts_api:
-            node.sendfrom("", common_address, fee)
         amount_to_send = 1.0
 
         # Create labels and make sure subsequent label API calls
         # recognize the label/address associations.
-        labels = [Label(name, accounts_api) for name in ("a", "b", "c", "d", "e")]
+        labels = [Label(name) for name in ("a", "b", "c", "d", "e")]
         for label in labels:
-            if accounts_api:
-                address = node.getaccountaddress(label.name)
-            else:
-                address = node.getnewaddress(label.name)
+            address = node.getnewaddress(label.name)
             label.add_receive_address(address)
             label.verify(node)
 
         # Check all labels are returned by listlabels.
         assert_equal(node.listlabels(), [label.name for label in labels])
 
-        # Send a transaction to each label, and make sure this forces
-        # getaccountaddress to generate a new receiving address.
+        # Send a transaction to each label.
         for label in labels:
-            if accounts_api:
-                node.sendtoaddress(label.receive_address, amount_to_send)
-                label.add_receive_address(node.getaccountaddress(label.name))
-            else:
-                node.sendtoaddress(label.addresses[0], amount_to_send)
+            node.sendtoaddress(label.addresses[0], amount_to_send)
             label.verify(node)
 
         # Check the amounts received.
@@ -120,32 +88,17 @@ class WalletLabelsTest(BitcoinTestFramework):
                 node.getreceivedbyaddress(label.addresses[0]), amount_to_send)
             assert_equal(node.getreceivedbylabel(label.name), amount_to_send)
 
-        # Check that sendfrom label reduces listaccounts balances.
         for i, label in enumerate(labels):
             to_label = labels[(i + 1) % len(labels)]
-            if accounts_api:
-                node.sendfrom(label.name, to_label.receive_address, amount_to_send)
-            else:
-                node.sendtoaddress(to_label.addresses[0], amount_to_send)
+            node.sendtoaddress(to_label.addresses[0], amount_to_send)
         node.generate(1)
         for label in labels:
-            if accounts_api:
-                address = node.getaccountaddress(label.name)
-            else:
-                address = node.getnewaddress(label.name)
+            address = node.getnewaddress(label.name)
             label.add_receive_address(address)
             label.verify(node)
             assert_equal(node.getreceivedbylabel(label.name), 2)
-            if accounts_api:
-                node.move(label.name, "", node.getbalance(label.name))
             label.verify(node)
         node.generate(101)
-        expected_account_balances = {"": 5200}
-        for label in labels:
-            expected_account_balances[label.name] = 0
-        if accounts_api:
-            assert_equal(node.listaccounts(), expected_account_balances)
-            assert_equal(node.getbalance(""), 5200)
 
         # Check that setlabel can assign a label to a new unused address.
         for label in labels:
@@ -153,10 +106,7 @@ class WalletLabelsTest(BitcoinTestFramework):
             node.setlabel(address, label.name)
             label.add_address(address)
             label.verify(node)
-            if accounts_api:
-                assert address not in node.getaddressesbyaccount("")
-            else:
-                assert_raises_rpc_error(-11, "No addresses with label", node.getaddressesbylabel, "")
+            assert_raises_rpc_error(-11, "No addresses with label", node.getaddressesbylabel, "")
 
         # Check that addmultisigaddress can assign labels.
         for label in labels:
@@ -167,35 +117,20 @@ class WalletLabelsTest(BitcoinTestFramework):
             label.add_address(multisig_address)
             label.purpose[multisig_address] = "send"
             label.verify(node)
-            if accounts_api:
-                node.sendfrom("", multisig_address, 50)
         node.generate(101)
-        if accounts_api:
-            for label in labels:
-                assert_equal(node.getbalance(label.name), 50)
 
         # Check that setlabel can change the label of an address from a
         # different label.
-        change_label(node, labels[0].addresses[0], labels[0], labels[1], accounts_api)
+        change_label(node, labels[0].addresses[0], labels[0], labels[1])
 
         # Check that setlabel can set the label of an address already
         # in the label. This is a no-op.
-        change_label(node, labels[2].addresses[0], labels[2], labels[2], accounts_api)
-
-        if accounts_api:
-            # Check that setaccount can change the label of an address which
-            # is the receiving address of a different label.
-            change_label(node, labels[0].receive_address, labels[0], labels[1], accounts_api)
-
-            # Check that setaccount can set the label of an address which is
-            # already the receiving address of the label. This is a no-op.
-            change_label(node, labels[2].receive_address, labels[2], labels[2], accounts_api)
+        change_label(node, labels[2].addresses[0], labels[2], labels[2])
 
 class Label:
-    def __init__(self, name, accounts_api):
+    def __init__(self, name):
         # Label name
         self.name = name
-        self.accounts_api = accounts_api
         # Current receiving address associated with this label.
         self.receive_address = None
         # List of all addresses assigned with this label
@@ -209,56 +144,31 @@ class Label:
 
     def add_receive_address(self, address):
         self.add_address(address)
-        if self.accounts_api:
-            self.receive_address = address
 
     def verify(self, node):
         if self.receive_address is not None:
             assert self.receive_address in self.addresses
-            if self.accounts_api:
-                assert_equal(node.getaccountaddress(self.name), self.receive_address)
 
         for address in self.addresses:
             assert_equal(
                 node.getaddressinfo(address)['labels'][0],
                 {"name": self.name,
                  "purpose": self.purpose[address]})
-            if self.accounts_api:
-                assert_equal(node.getaccount(address), self.name)
-            else:
-                assert_equal(node.getaddressinfo(address)['label'], self.name)
+            assert_equal(node.getaddressinfo(address)['label'], self.name)
 
         assert_equal(
             node.getaddressesbylabel(self.name),
             {address: {"purpose": self.purpose[address]} for address in self.addresses})
-        if self.accounts_api:
-            assert_equal(set(node.getaddressesbyaccount(self.name)), set(self.addresses))
-
 
-def change_label(node, address, old_label, new_label, accounts_api):
+def change_label(node, address, old_label, new_label):
     assert_equal(address in old_label.addresses, True)
-    if accounts_api:
-        node.setaccount(address, new_label.name)
-    else:
-        node.setlabel(address, new_label.name)
+    node.setlabel(address, new_label.name)
 
     old_label.addresses.remove(address)
     new_label.add_address(address)
 
-    # Calling setaccount on an address which was previously the receiving
-    # address of a different account should reset the receiving address of
-    # the old account, causing getaccountaddress to return a brand new
-    # address.
-    if accounts_api:
-        if old_label.name != new_label.name and address == old_label.receive_address:
-            new_address = node.getaccountaddress(old_label.name)
-            assert_equal(new_address not in old_label.addresses, True)
-            assert_equal(new_address not in new_label.addresses, True)
-            old_label.add_receive_address(new_address)
-
     old_label.verify(node)
     new_label.verify(node)
 
-
 if __name__ == '__main__':
     WalletLabelsTest().main()