diff options
| author | fanquake <fanquake@gmail.com> | 2023-08-01 16:42:38 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-08-01 16:56:15 +0100 |
| commit | eb95368e0c3ab3d9f5f88630c2bd81ad1b01988a (patch) | |
| tree | 90f7661dbe670de861ec181c8990e1e0f67fd976 /test/functional/wallet_fundrawtransaction.py | |
| parent | ceda8198868ba960e3dc5c745031b35975f0d064 (diff) | |
| parent | 90c8f79e945863f3818748b86572948d1558aec3 (diff) | |
| download | bitcoin-eb95368e0c3ab3d9f5f88630c2bd81ad1b01988a.tar.xz | |
Merge bitcoin/bitcoin#28166: test, rpc: invalid sighashtype coverage
90c8f79e945863f3818748b86572948d1558aec3 test: remove redundant test values (Jon Atack)
c3f203387df60c596a1e416658d87d68b85adbf2 test: use common assert_signing_completed_successfully helper (Jon Atack)
647d95aae9720543c2c9c46c70191e6f9f775d66 test: add coverage for passing an invalid sighashtype (Jon Atack)
Pull request description:
Add test coverage for passing an invalid sighashtype to RPCs signrawtransactionwithwallet, signrawtransactionwithkey, walletprocesspsbt, and descriptorprocesspsbt.
ACKs for top commit:
MarcoFalke:
lgtm ACK 90c8f79e945863f3818748b86572948d1558aec3 🎥
brunoerg:
light crACK 90c8f79e945863f3818748b86572948d1558aec3
Tree-SHA512: 3861658487edd0d9a377390acf3d43f45c3dd9e324894f0fdb8f5312b618301a55479b1f70c61daee0b20785e768ffde6fa5abe6af190b73c0d0e017f3976704
Diffstat (limited to 'test/functional/wallet_fundrawtransaction.py')
| -rwxr-xr-x | test/functional/wallet_fundrawtransaction.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/wallet_fundrawtransaction.py b/test/functional/wallet_fundrawtransaction.py index 4778a8e567..e367daae2c 100755 --- a/test/functional/wallet_fundrawtransaction.py +++ b/test/functional/wallet_fundrawtransaction.py @@ -832,7 +832,7 @@ class RawTransactionsTest(BitcoinTestFramework): for invalid_value in ["", 0.000000001, 1e-09, 1.111111111, 1111111111111111, "31.999999999999999999999"]: assert_raises_rpc_error(-3, "Invalid amount", node.fundrawtransaction, rawtx, add_inputs=True, **{param: invalid_value}) # Test fee_rate values that cannot be represented in sat/vB. - for invalid_value in [0.0001, 0.00000001, 0.00099999, 31.99999999, "0.0001", "0.00000001", "0.00099999", "31.99999999"]: + for invalid_value in [0.0001, 0.00000001, 0.00099999, 31.99999999]: assert_raises_rpc_error(-3, "Invalid amount", node.fundrawtransaction, rawtx, fee_rate=invalid_value, add_inputs=True) |