diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-10-21 16:46:11 +0200 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-10-21 17:42:03 +0200 |
| commit | ee1294f155a4d1d5c6dd41fedf76f7895e0b0746 (patch) | |
| tree | 70951ecf68e4ea82ff76507fe67cbe19acf5dfa2 /test/functional/wallet_basic.py | |
| parent | 88fc7950f8db5f13a6b259819aced2e3db7ff4d8 (diff) | |
| parent | 96f469f91bc02a19703344cc439eab064b72081a (diff) | |
| download | bitcoin-ee1294f155a4d1d5c6dd41fedf76f7895e0b0746.tar.xz | |
Merge bitcoin/bitcoin#23324: Print peer counts for all reachable networks in -netinfo
96f469f91bc02a19703344cc439eab064b72081a netinfo: print peer counts for all reachable networks (Jon Atack)
Pull request description:
instead of only for networks we have peer connections to.
Users reported the previous behavior caused confusion, as no column was printed when a network was reachable but no peers were connected. Users expected a column to be printed with 0 peers. This commit aligns behavior with that expectation.
In addition, the ipv4, ipv6, and onion columns were always printed whether or not they were reachable. With this change, only the reachable ones will be returned.
Example with CJDNS reachable but no CJDNS peers (built on #23077 and #23175):
before
```
ipv4 ipv6 onion i2p total block manual
in 0 0 12 5 17
out 8 1 6 4 19 2 8
total 8 1 18 9 36
```
after
```
ipv4 ipv6 onion i2p cjdns total block manual
in 0 0 12 5 0 17
out 8 1 6 4 0 19 2 8
total 8 1 18 9 0 36
```
There is one additional space between the in/out/total row headers and the network counts.
ACKs for top commit:
jsarenik:
Tested ACK 96f469f91
prayank23:
utACK https://github.com/bitcoin/bitcoin/commit/96f469f91bc02a19703344cc439eab064b72081a
laanwj:
Code review and lightly tested ACK 96f469f91bc02a19703344cc439eab064b72081a
naumenkogs:
ACK 96f469f91bc02a19703344cc439eab064b72081a.
hebasto:
ACK 96f469f91bc02a19703344cc439eab064b72081a, tested by comparing the output of `watch src/bitcoin-cli -netinfo` with the Peer tab of the Node window in the GUI :tiger2:
Tree-SHA512: 3489f40148a2bd0afc9eef1e1577d44150c1fccec8dbf2a675bc23aa9343bfcae6c4039f5b96e54730668c83f40bc932fb6808f5540e86ff7249fde8dc0fff67
Diffstat (limited to 'test/functional/wallet_basic.py')
0 files changed, 0 insertions, 0 deletions