diff options
| author | Jon Atack <jon@atack.com> | 2023-03-19 19:26:14 -0700 |
|---|---|---|
| committer | Jon Atack <jon@atack.com> | 2023-04-10 10:41:56 -0700 |
| commit | 645d7f75ac1b40e4ea88119b3711f89943d35d6c (patch) | |
| tree | 94fa05d0f6af85e0ef0e31ef2e62e9f44c7b4f80 /test/functional/wallet_backwards_compatibility.py | |
| parent | 2f4a926e95e0379397859c3ba1b5711be5f09925 (diff) | |
| download | bitcoin-645d7f75ac1b40e4ea88119b3711f89943d35d6c.tar.xz | |
rpc: deprecate "warning" field in {create,load,unload,restore}wallet
This string field has been replaced in these four RPCs by a "warnings" field
returning a JSON array of strings.
Diffstat (limited to 'test/functional/wallet_backwards_compatibility.py')
| -rwxr-xr-x | test/functional/wallet_backwards_compatibility.py | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/test/functional/wallet_backwards_compatibility.py b/test/functional/wallet_backwards_compatibility.py index 76aac3e486..a6401a76c1 100755 --- a/test/functional/wallet_backwards_compatibility.py +++ b/test/functional/wallet_backwards_compatibility.py @@ -265,7 +265,12 @@ class BackwardsCompatibilityTest(BitcoinTestFramework): ) load_res = node_master.loadwallet("u1_v16") # Make sure this wallet opens without warnings. See https://github.com/bitcoin/bitcoin/pull/19054 - assert_equal(load_res['warning'], '') + if int(node_master.getnetworkinfo()["version"]) >= 249900: + # loadwallet#warnings (added in v25) -- only present if there is a warning + assert "warnings" not in load_res + else: + # loadwallet#warning (deprecated in v25) -- always present, but empty string if no warning + assert_equal(load_res["warning"], '') wallet = node_master.get_wallet_rpc("u1_v16") info = wallet.getaddressinfo(v16_addr) descriptor = f"wpkh([{info['hdmasterfingerprint']}{hdkeypath[1:]}]{v16_pubkey})" |