diff options
| author | fanquake <fanquake@gmail.com> | 2023-08-01 16:56:39 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-08-01 16:59:37 +0100 |
| commit | 1b5cbf71dff1f240bac0156f8800382272489f0b (patch) | |
| tree | ee5affb363819dcc17b5726f236dc6ebbd59d986 /test/functional/tool_wallet.py | |
| parent | eb95368e0c3ab3d9f5f88630c2bd81ad1b01988a (diff) | |
| parent | 8a20f765cce2fc0fadf1a2b66b843b67f2d2ae12 (diff) | |
| download | bitcoin-1b5cbf71dff1f240bac0156f8800382272489f0b.tar.xz | |
Merge bitcoin/bitcoin#28144: test: fix intermittent failure in p2p_getaddr_caching.py
8a20f765cce2fc0fadf1a2b66b843b67f2d2ae12 test: drop duplicate getaddrs from p2p_getaddr_caching (Martin Zumsande)
feb0096139e9e864632d2826d2e213b26146fff1 test: fix intermittent failure in p2p_getaddr_caching (Martin Zumsande)
Pull request description:
Fixes #28133
In the consistency check, it's not enough to check that our address/port is unique, only the combination of source and target must be unique. Otherwise, the OS may reuse ports for connections to different `-addrbind`, which was happening in the failed runs.
While at it, the second commit cleans up duplicate `getaddr` messages in `p2p_getaddr_caching.py` that do nothing but generate `Ignoring repeated "getaddr"` log messages (and cleans up some whitespace the python linter complains about).
ACKs for top commit:
vasild:
ACK 8a20f765cce2fc0fadf1a2b66b843b67f2d2ae12
Tree-SHA512: eabe4727d7887f729074076f6333a918bba8cb34b8e3baaa83f167b441b0daa24f7c4824abcf03a9538a2ef14b2d826ff19aeffcb93a6c20735253a9678aac9c
Diffstat (limited to 'test/functional/tool_wallet.py')
0 files changed, 0 insertions, 0 deletions