diff options
| author | Ava Chow <github@achow101.com> | 2024-09-04 15:28:41 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-09-04 15:28:41 -0400 |
| commit | 5373aa30e28cf67b5c723e807a339c80fde1feef (patch) | |
| tree | a9e3e21538f373b77320d297c2735ea7f56af1fe /test/functional/test_framework | |
| parent | 3210d87dfccd828be5f68ab62b05ded29a55c341 (diff) | |
| parent | ae48a22a3df086fb59843b7b814619ed5df7557b (diff) | |
Merge bitcoin/bitcoin#30788: test: fixing failing system_tests/run_command under some Locales
ae48a22a3df086fb59843b7b814619ed5df7557b test: fixing failing system_tests/run_command under some Locales (Jadi)
Pull request description:
the run_command test under system_tests fails if the locale is anything
other than English ones because results such as "No such file or directory"
will be different under Non-English locales.
On the old version, a `ls nonexistingfile` was used to generate the error
output which is not ideal. In the current version we are using a Python one-liner
to generate a non 0 zero return value and "err" on stderr and check the
expected value against this.
fixes https://github.com/bitcoin/bitcoin/issues/30608
ACKs for top commit:
maflcko:
review ACK ae48a22a3df086fb59843b7b814619ed5df7557b
achow101:
ACK ae48a22a3df086fb59843b7b814619ed5df7557b
hebasto:
ACK ae48a22a3df086fb59843b7b814619ed5df7557b, tested on Ubuntu 24.04 by switching locale.
Tree-SHA512: af7522ddcd786fa4a6832c8336ca89d8ff05f49ff963cbe1a96653b0edf29e0f950a032f23d742b16b3895e90cf5117b5f6a95464268dec67039df166d7d8639
Diffstat (limited to 'test/functional/test_framework')
0 files changed, 0 insertions, 0 deletions