diff options
author | MarcoFalke <falke.marco@gmail.com> | 2021-05-24 11:11:55 +0200 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2021-05-24 11:14:23 +0200 |
commit | ce4a852475fc445be88685197ea48c19256e0401 (patch) | |
tree | fa543f1b6f2178aad66d6f387a4f79eaec3663df /test/functional/test_framework/test_shell.py | |
parent | 599000903e09e5ae3784d15ae078a2e1ed89ab12 (diff) | |
parent | fafd121026c4f1e25d498983e4f88c119516552b (diff) | |
download | bitcoin-ce4a852475fc445be88685197ea48c19256e0401.tar.xz |
Merge bitcoin/bitcoin#21848: refactor: Make CFeeRate constructor architecture-independent
fafd121026c4f1e25d498983e4f88c119516552b refactor: Make CFeeRate constructor architecture-independent (MarcoFalke)
Pull request description:
Currently the constructor is architecture dependent. This is confusing for several reasons:
* It is impossible to create a transaction larger than the max value of `uint32_t`, so a 64-bit `size_t` is not needed
* Policy (and consensus) code should be arch-independent
* The current code will print spurious compile errors when compiled on 32-bit systems:
```
policy/feerate.cpp:23:22: warning: result of comparison of constant 9223372036854775807 with expression of type 'size_t' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare]
assert(nBytes_ <= uint64_t(std::numeric_limits<int64_t>::max()));
```
Fix all issues by making it arch-independent. Also, fix `{}` style according to dev notes.
ACKs for top commit:
theStack:
re-ACK fafd121026c4f1e25d498983e4f88c119516552b
promag:
Code review ACK fafd121026c4f1e25d498983e4f88c119516552b.
Tree-SHA512: e16f75bad9ee8088b87e873906d9b5633449417a6996a226a2f37d33a2b7d4f2fd91df68998a77e52163de20b40c57fadabe7fe3502e599cbb98494178591833
Diffstat (limited to 'test/functional/test_framework/test_shell.py')
0 files changed, 0 insertions, 0 deletions