diff options
| author | fanquake <fanquake@gmail.com> | 2023-11-01 10:05:28 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-11-01 10:08:58 +0000 |
| commit | 9d594ed1d88ad4aad3dda4ff62acad61f060fe99 (patch) | |
| tree | a12a62b77395bc61660e93417fc8b77793eb8388 /test/functional/test_framework/test_node.py | |
| parent | 04bfe8c9c3ffd066b6103a4d49f54c33a13f1053 (diff) | |
| parent | b74e449ffa9965f18037f0322ea178e2fe1dbc18 (diff) | |
| download | bitcoin-9d594ed1d88ad4aad3dda4ff62acad61f060fe99.tar.xz | |
Merge bitcoin/bitcoin#28755: build: remove duplicate `-lminiupnpc` linking
b74e449ffa9965f18037f0322ea178e2fe1dbc18 build: remove potential for duplciate natpmp linking (fanquake)
4e9509695206bd952da00a2b1c90a92db31a0fe7 build: remove duplicate -lminiupnpc linking (fanquake)
Pull request description:
Having the link check in the header check loop means we get `-lminiupnpc -lminiupnpc -lminiupnpc` on the link line.
This is unnecessary, and results in warnings, i.e:
```bash
ld: warning: ignoring duplicate libraries: '-levent', '-lminiupnpc'
ld: warning: ignoring duplicate libraries: '-levent', '-lminiupnpc'
ld: warning: ignoring duplicate libraries: '-levent', '-lminiupnpc'
```
These warnings have been occurring since the new macOS linker released with Xcode 15, and also came up in https://github.com/hebasto/bitcoin/pull/34.
There are other duplicate lib issues, i.e with `-levent` + `-levent_pthreads -levent`, but those are less straight forward to solve, and won't be included here.
ACKs for top commit:
jonatack:
ACK b74e449ffa9965f18037f0322ea178e2fe1dbc18
hebasto:
ACK b74e449ffa9965f18037f0322ea178e2fe1dbc18, it fixes one issue mentioned in https://github.com/hebasto/bitcoin/pull/34#issuecomment-1782914787.
TheCharlatan:
ACK b74e449ffa9965f18037f0322ea178e2fe1dbc18
theuni:
ACK b74e449ffa9965f18037f0322ea178e2fe1dbc18
Tree-SHA512: 987a56ef17cbaf273cb672c41016f3f615b16889317325a9e88135d0c41f01af3840ad44a6f811a7df97f5873c9cd957e60aaa1b99bd408b17b4b1ffe2c68f36
Diffstat (limited to 'test/functional/test_framework/test_node.py')
0 files changed, 0 insertions, 0 deletions