diff options
author | Ava Chow <github@achow101.com> | 2024-05-10 13:18:00 -0400 |
---|---|---|
committer | Ava Chow <github@achow101.com> | 2024-05-10 13:18:00 -0400 |
commit | 2cedb42a928fbf3a1e0e8715e918497cbe64af0d (patch) | |
tree | 4d75ab6b60cb9c9f2bfb8f8f51dec41e613f12e2 /test/functional/test_framework/crypto/secp256k1.py | |
parent | 7066980273aa5f405ae34b71ead7f0bf0132e1b7 (diff) | |
parent | 96378fe734e5fb6167eb20036d7170572a647edb (diff) |
Merge bitcoin/bitcoin#29252: kernel: Remove key module from kernel library
96378fe734e5fb6167eb20036d7170572a647edb Refactor: Remove ECC_Start and ECC_Stop from key header (TheCharlatan)
41eba5bd716bea47c8731d156d053afee92a7f12 kernel: Remove key module from kernel library (TheCharlatan)
a08d2b3cb971c68e9a50b991b2953fa4541cf48a tools: Use ECC_Context helper in bitcoin-tx and bitcoin-wallet tools (Ryan Ofsky)
28905c1a64a87a56f16aea8a4d23dea7eec9ca59 test: Use ECC_Context helper in bench and fuzz tests (Ryan Ofsky)
538fedde1d9c96a2bbe06cacc0cd6903135fbc83 common: Add ECC_Context RAII wrapper for ECC_Start/ECC_Stop (Ryan Ofsky)
Pull request description:
The key module's functionality is not used by the kernel library, but currently kernel users are still required to initialize the key module's `secp256k1_context_sign` global as part of the `kernel::Context` through `ECC_Start`. So move the `ECC_Start` call to the `NodeContext` ctor instead to completely remove the key module from the kernel library.
The gui tests currently keep multiple `NodeContext` objects in memory, so call `ECC_Stop` manually to avoid triggering an assertion on `ECC_Start`.
---
This PR is part of the [libbitcoinkernel project](https://github.com/bitcoin/bitcoin/issues/27587). It removes a module from the kernel library.
ACKs for top commit:
achow101:
ACK 96378fe734e5fb6167eb20036d7170572a647edb
ryanofsky:
Code review ACK 96378fe734e5fb6167eb20036d7170572a647edb. Just suggested comment changes since last review.
theuni:
utACK 96378fe734e5fb6167eb20036d7170572a647edb
Tree-SHA512: 40be427e8e2c920c0e3ce64a9bdd90551be27a89af11440bfb6ab0dd3a1d1ccb7cf1f82383cd782818cd1bb44d5ae5d2161cf4d78d3127ce4987342007090bab
Diffstat (limited to 'test/functional/test_framework/crypto/secp256k1.py')
0 files changed, 0 insertions, 0 deletions