diff options
author | glozow <gloriajzhao@gmail.com> | 2022-09-28 14:07:56 +0100 |
---|---|---|
committer | glozow <gloriajzhao@gmail.com> | 2023-01-10 11:07:38 +0000 |
commit | 601bac88cb95404e7d38ac6348d959c0e06bd922 (patch) | |
tree | a09a4eb8113f024cc6bb7330efdeeb87f3ad4f1c /test/functional/rpc_packages.py | |
parent | 1691eaa818f7a7b22907f756490b842d80a9a21d (diff) | |
download | bitcoin-601bac88cb95404e7d38ac6348d959c0e06bd922.tar.xz |
[rpc] return effective-includes in testmempoolaccept and submitpackage
Diffstat (limited to 'test/functional/rpc_packages.py')
-rwxr-xr-x | test/functional/rpc_packages.py | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/test/functional/rpc_packages.py b/test/functional/rpc_packages.py index f3b5f4d2dc..ba782c5bb9 100755 --- a/test/functional/rpc_packages.py +++ b/test/functional/rpc_packages.py @@ -247,6 +247,7 @@ class RPCPackagesTest(BitcoinTestFramework): assert_equal(testres_replaceable["vsize"], replaceable_tx["tx"].get_vsize()) assert_equal(testres_replaceable["fees"]["base"], fee) assert_fee_amount(fee, replaceable_tx["tx"].get_vsize(), testres_replaceable["fees"]["effective-feerate"]) + assert_equal(testres_replaceable["fees"]["effective-includes"], [replaceable_tx["wtxid"]]) # Replacement transaction is identical except has double the fee replacement_tx = self.wallet.create_self_transfer(utxo_to_spend=coin, sequence=MAX_BIP125_RBF_SEQUENCE, fee = 2 * fee) @@ -315,6 +316,7 @@ class RPCPackagesTest(BitcoinTestFramework): assert_equal(tx_result["fees"]["base"], DEFAULT_FEE) if wtxid not in presubmitted_wtxids: assert_fee_amount(DEFAULT_FEE, tx.get_vsize(), tx_result["fees"]["effective-feerate"]) + assert_equal(tx_result["fees"]["effective-includes"], [wtxid]) # submitpackage result should be consistent with testmempoolaccept and getmempoolentry self.assert_equal_package_results(node, testmempoolaccept_result, submitpackage_result) @@ -353,10 +355,13 @@ class RPCPackagesTest(BitcoinTestFramework): assert_equal(child_result["fees"]["base"], DEFAULT_FEE) # The "rich" parent does not require CPFP so its effective feerate. assert_fee_amount(DEFAULT_FEE, tx_rich["tx"].get_vsize(), rich_parent_result["fees"]["effective-feerate"]) + assert_equal(rich_parent_result["fees"]["effective-includes"], [tx_rich["wtxid"]]) # The "poor" parent and child's effective feerates are the same, composed of the child's fee # divided by their combined vsize. assert_fee_amount(DEFAULT_FEE, tx_poor["tx"].get_vsize() + tx_child["tx"].get_vsize(), poor_parent_result["fees"]["effective-feerate"]) assert_fee_amount(DEFAULT_FEE, tx_poor["tx"].get_vsize() + tx_child["tx"].get_vsize(), child_result["fees"]["effective-feerate"]) + assert_equal([tx_poor["wtxid"], tx_child["tx"].getwtxid()], poor_parent_result["fees"]["effective-includes"]) + assert_equal([tx_poor["wtxid"], tx_child["tx"].getwtxid()], child_result["fees"]["effective-includes"]) # Package feerate is calculated for the remaining transactions after deduplication and # individual submission. Since this package had a 0-fee parent, package feerate must have |