diff options
| author | Andrew Chow <github@achow101.com> | 2023-01-03 12:53:23 -0500 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-01-03 13:02:20 -0500 |
| commit | cb552c5f21192d2f8f69c07130928c21301a5e7f (patch) | |
| tree | f730520604b3b687596a0c36a81ac66b5e52e4bf /test/functional/rpc_blockchain.py | |
| parent | 65d7c31b3f5f08777d0449177bf07e16d7df1424 (diff) | |
| parent | 04609284ad5e0b72651f2d4b43263461ada40816 (diff) | |
| download | bitcoin-cb552c5f21192d2f8f69c07130928c21301a5e7f.tar.xz | |
Merge bitcoin/bitcoin#26192: rpc: Improve error when wallet is already loaded
04609284ad5e0b72651f2d4b43263461ada40816 rpc: Improve error when wallet is already loaded (Aurèle Oulès)
Pull request description:
Currently, trying to load a descriptor (sqlite) wallet that is already loaded throws the following error:
> error code: -4
> error message:
> Wallet file verification failed. SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of Bitcoin Core?
I don't think it is very clear what it means for a user.
While a legacy wallet would throw:
> error code: -35
> error message:
> Wallet file verification failed. Refusing to load database. Data file '/home/user/.bitcoin/signet/wallets/test_wallet/wallet.dat' is already loaded.
This PR changes the error message for both types of wallet to:
> error code: -35
> error message:
> Wallet file verification failed. Wallet "test_wallet" is already loaded.
ACKs for top commit:
achow101:
ACK 04609284ad5e0b72651f2d4b43263461ada40816
hernanmarino:
ACK 0460928
theStack:
Tested ACK 04609284ad5e0b72651f2d4b43263461ada40816
Tree-SHA512: a8f3d5133bfaef7417a6c05d160910ea08f32ac62bfdf7f5ec305ff5b62e9113b55f385abab4d5a4ad711aabcb1eb7ef746eb41f841b196e8fb5393ab3ccc01e
Diffstat (limited to 'test/functional/rpc_blockchain.py')
0 files changed, 0 insertions, 0 deletions