diff options
| author | Ava Chow <github@achow101.com> | 2024-05-03 12:36:00 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-05-03 12:36:00 -0400 |
| commit | f9486de6a96b624982a2d45b895bfe4e865063d1 (patch) | |
| tree | 706145d7e578f6cc663388d007ddbbbe844a931d /test/functional/p2p_segwit.py | |
| parent | 70e4d6ff1d269abbda9dafae659e3da3ea17867a (diff) | |
| parent | af3c18169a075222fe0795ab24b8b20ad5e30ae4 (diff) | |
Merge bitcoin/bitcoin#30029: test: remove duplicate `WITNESS_SCALE_FACTOR` constant definition
af3c18169a075222fe0795ab24b8b20ad5e30ae4 [test]: remove duplicate WITNESS_SCALE_FACTOR (ismaelsadeeq)
Pull request description:
Notice this while working on #29523
- `blocktools.py` and `messages.py` both define `WITNESS_SCALE_FACTOR` constant
https://github.com/bitcoin/bitcoin/blob/99d7538cdb2a0ab7a7a2116cd5f33b95fc52b00e/test/functional/test_framework/blocktools.py#L48
https://github.com/bitcoin/bitcoin/blob/99d7538cdb2a0ab7a7a2116cd5f33b95fc52b00e/test/functional/test_framework/messages.py#L68
- This PR deletes the one in `blocktools.py` and update the tests to only use `WITNESS_SCALE_FACTOR` from `messages.py`
ACKs for top commit:
maflcko:
ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
sipa:
ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
achow101:
ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
glozow:
lgtm ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
brunoerg:
ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
willcl-ark:
ACK af3c18169a075222fe0795ab24b8b20ad5e30ae4
Tree-SHA512: 6bd8060c9eea10e03940acee2aa4cd08e4e0afb6d26be3e6300ad405fd0af5b373a00e994eb39515a2dcafa1625562bcd57945049a84b9c9dcc7ea60c24f0911
Diffstat (limited to 'test/functional/p2p_segwit.py')
0 files changed, 0 insertions, 0 deletions