diff options
| author | fanquake <fanquake@gmail.com> | 2024-04-02 11:06:31 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2024-04-02 11:06:35 +0100 |
| commit | 1d8a5f0d9bd00d0f585d77b8e70a3e51fda79cb9 (patch) | |
| tree | 1b8e8a336b3f41c56f13d6d13d437bec9d238eac /test/functional/p2p_node_network_limited.py | |
| parent | 23ba39470c3d155a65f0616f8848ada730658301 (diff) | |
| parent | 61560d5e939034e1a94d95cdc5c498095ab4fddb (diff) | |
Merge bitcoin/bitcoin#29750: test: makes timeout a forced named argument in tests methods that use it
61560d5e939034e1a94d95cdc5c498095ab4fddb test: makes timeout a forced named argument in tests methods that use it (Sergi Delgado Segura)
Pull request description:
This makes calls to such methods more explicit and less error-prone.
Motivated by https://github.com/bitcoin/bitcoin/pull/29736#discussion_r1540654057
ACKs for top commit:
maflcko:
lgtm ACK 61560d5e939034e1a94d95cdc5c498095ab4fddb
brunoerg:
ACK 61560d5e939034e1a94d95cdc5c498095ab4fddb
BrandonOdiwuor:
crACK 61560d5e939034e1a94d95cdc5c498095ab4fddb
AngusP:
ACK 61560d5e939034e1a94d95cdc5c498095ab4fddb
stratospher:
tested ACK 61560d5.
Tree-SHA512: 8d6ec3fe1076c868ddbd3050f3c242dbd83cc123f560db3d3b0ed74968e6050dc9ebf4e7c716af9cc1b290c97d736c2fc2ac936b0b69ebdbceed934dae7d55d9
Diffstat (limited to 'test/functional/p2p_node_network_limited.py')
| -rwxr-xr-x | test/functional/p2p_node_network_limited.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/p2p_node_network_limited.py b/test/functional/p2p_node_network_limited.py index 8f145b954a..8b63d8ee26 100755 --- a/test/functional/p2p_node_network_limited.py +++ b/test/functional/p2p_node_network_limited.py @@ -138,7 +138,7 @@ class NodeNetworkLimitedTest(BitcoinTestFramework): self.log.info("Requesting block at height 2 (tip-289) must fail (ignored).") node.send_getdata_for_block(blocks[0]) # first block outside of the 288+2 limit - node.wait_for_disconnect(5) + node.wait_for_disconnect(timeout=5) self.nodes[0].disconnect_p2ps() # connect unsynced node 2 with pruned NODE_NETWORK_LIMITED peer |