aboutsummaryrefslogtreecommitdiff
path: root/test/functional/p2p_handshake.py
diff options
context:
space:
mode:
authorSebastian Falbesoner <sebastian.falbesoner@gmail.com>2024-07-01 20:49:18 +0200
committerSebastian Falbesoner <sebastian.falbesoner@gmail.com>2024-07-01 20:53:16 +0200
commit9ec2c53701a391629b55aeb2804e8060d2c453a4 (patch)
treedefe7dc9edefb9087e89e590e72a420f7e97fdee /test/functional/p2p_handshake.py
parentfe70be537783aeadf9e3f72cad07efd66775285b (diff)
Revert "test: p2p: check that connecting to ourself leads to disconnect"
This reverts commit 5d2fb14bafe4e80c0a482d99e5ebde07c477f000 and adds a TODO to add it later again once the race condition is fixed.
Diffstat (limited to 'test/functional/p2p_handshake.py')
-rwxr-xr-xtest/functional/p2p_handshake.py9
1 files changed, 3 insertions, 6 deletions
diff --git a/test/functional/p2p_handshake.py b/test/functional/p2p_handshake.py
index 673322ab10..21959ae522 100755
--- a/test/functional/p2p_handshake.py
+++ b/test/functional/p2p_handshake.py
@@ -17,7 +17,6 @@ from test_framework.messages import (
NODE_WITNESS,
)
from test_framework.p2p import P2PInterface
-from test_framework.util import p2p_port
# Desirable service flags for outbound non-pruned and pruned peers. Note that
@@ -89,11 +88,9 @@ class P2PHandshakeTest(BitcoinTestFramework):
with node.assert_debug_log([f"feeler connection completed"]):
self.add_outbound_connection(node, "feeler", NODE_NONE, wait_for_disconnect=True)
- self.log.info("Check that connecting to ourself leads to immediate disconnect")
- with node.assert_debug_log(["connected to self", "disconnecting"]):
- node_listen_addr = f"127.0.0.1:{p2p_port(0)}"
- node.addconnection(node_listen_addr, "outbound-full-relay", self.options.v2transport)
- self.wait_until(lambda: len(node.getpeerinfo()) == 0)
+ # TODO: re-add test introduced in commit 5d2fb14bafe4e80c0a482d99e5ebde07c477f000
+ # ("test: p2p: check that connecting to ourself leads to disconnect") once
+ # the race condition causing issue #30368 is fixed
if __name__ == '__main__':