diff options
| author | John Newbery <john@johnnewbery.com> | 2021-10-01 17:26:08 +0100 |
|---|---|---|
| committer | John Newbery <john@johnnewbery.com> | 2021-10-28 14:00:21 +0100 |
| commit | 2095df7b7bfcb9ab0c5710a93112f7f341e753c9 (patch) | |
| tree | 22703ab84a8823e7ad923d8d6532ebb885d74aa7 /test/functional/p2p_addrv2_relay.py | |
| parent | 2658eb6d68460272deefb3fcc653b03f6ec6e7cf (diff) | |
| download | bitcoin-2095df7b7bfcb9ab0c5710a93112f7f341e753c9.tar.xz | |
[addrman] Add Add_() inner function, fix Add() return semantics
Previously, Add() would return true if the function created a new
AddressInfo object, even if that object could not be successfully
entered into the new table and was deleted. That would happen if the new
table position was already taken and the existing entry could not be
removed.
Instead, return true if the new AddressInfo object is successfully
entered into the new table. This fixes a bug in the "Added %i addresses"
log, which would not always accurately log how many addresses had been
added.
p2p_addrv2_relay.py and p2p_addr_relay.py need to be updated since they
were incorrectly asserting on the buggy log (assuming that addresses are
added to addrman, when there could in fact be new table position
collisions that prevent some of those address records from being added).
Diffstat (limited to 'test/functional/p2p_addrv2_relay.py')
| -rwxr-xr-x | test/functional/p2p_addrv2_relay.py | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/test/functional/p2p_addrv2_relay.py b/test/functional/p2p_addrv2_relay.py index 3833c58680..f4be893d2c 100755 --- a/test/functional/p2p_addrv2_relay.py +++ b/test/functional/p2p_addrv2_relay.py @@ -72,9 +72,6 @@ class AddrTest(BitcoinTestFramework): addr_receiver = self.nodes[0].add_p2p_connection(AddrReceiver()) msg.addrs = ADDRS with self.nodes[0].assert_debug_log([ - # The I2P address is not added to node's own addrman because it has no - # I2P reachability (thus 10 - 1 = 9). - 'Added 9 addresses from 127.0.0.1: 0 tried', 'received: addrv2 (159 bytes) peer=0', 'sending addrv2 (159 bytes) peer=1', ]): |