diff options
| author | Ava Chow <github@achow101.com> | 2024-05-17 15:50:56 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-05-17 15:50:56 -0400 |
| commit | 058af75874ffa2b4064e3d6d30cc50f0ec754ba8 (patch) | |
| tree | 9251b58d1f98cd681bca7cdd649c5cca7830ebde /test/functional/p2p_1p1c_network.py | |
| parent | 4877fcdb4263fc3582184fdab3e5d1533c64a7d5 (diff) | |
| parent | b47bd959207e82555f07e028cc2246943d32d4c3 (diff) | |
Merge bitcoin/bitcoin#29817: kernel: De-globalize fReindex
b47bd959207e82555f07e028cc2246943d32d4c3 kernel: De-globalize fReindex (TheCharlatan)
Pull request description:
fReindex is one of the last remaining globals exposed by the kernel library, so move it into the blockstorage class to reduce the amount of global mutable state and make the kernel library a bit less awkward to use.
---
This pull request is part of the [libbitcoinkernel project](https://github.com/bitcoin/bitcoin/issues/27587).
ACKs for top commit:
achow101:
ACK b47bd959207e82555f07e028cc2246943d32d4c3
ryanofsky:
Code review ACK b47bd959207e82555f07e028cc2246943d32d4c3. I rereviewed the whole PR, but the only change since last review was reverting the bugfix https://github.com/bitcoin/bitcoin/pull/29817#discussion_r1578327024 and make the change a pure refactoring.
mzumsande:
Code Review ACK b47bd959207e82555f07e028cc2246943d32d4c3
stickies-v:
ACK b47bd959207e82555f07e028cc2246943d32d4c3
Tree-SHA512: f7399d01f93bc0c0c7428fe95d19b9d29b4ed00a4f1deabca78fb0c4fecb434ec971e890feecb105938b5247c926850b1b7b4a4a9caa333a061e40777d0c8463
Diffstat (limited to 'test/functional/p2p_1p1c_network.py')
0 files changed, 0 insertions, 0 deletions