diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-11-14 08:56:04 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-11-14 08:56:37 +0100 |
| commit | 7adeea3b0fc26025c06590125a48ce2651c66373 (patch) | |
| tree | e05cb13e84c54ec6ab71d2ffb754feeb2e5c585a /test/functional/p2p-leaktests.py | |
| parent | cbb54e77a120a69fc6faaecbdc4cf93915afb89c (diff) | |
| parent | faaa7db25e94cf02818865e3d27707d6acaa1e25 (diff) | |
| download | bitcoin-7adeea3b0fc26025c06590125a48ce2651c66373.tar.xz | |
Merge #11641: qa: Only allow disconnecting all NodeConns
faaa7db qa: Only allow disconnecting all NodeConns (MarcoFalke)
Pull request description:
Disconnecting the connection with `index=0` makes no sense when there are more than one connections, as the list "rotates around" and populates index 0 after `del`.
Just disconnect all NodeConns in any case.
Tree-SHA512: e5cf540823fccb31634b5a11501f54222be89862e80ccafc28bc06726480f8d2153b8c1b6f859fa6a6d087876251d48a6c6035bccdaaf16831e300bc17ff613d
Diffstat (limited to 'test/functional/p2p-leaktests.py')
| -rwxr-xr-x | test/functional/p2p-leaktests.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/test/functional/p2p-leaktests.py b/test/functional/p2p-leaktests.py index a6e47b5df6..719a03914d 100755 --- a/test/functional/p2p-leaktests.py +++ b/test/functional/p2p-leaktests.py @@ -125,8 +125,7 @@ class P2PLeakTest(BitcoinTestFramework): assert not unsupported_service_bit5_node.connected assert not unsupported_service_bit7_node.connected - for _ in range(5): - self.nodes[0].disconnect_p2p() + self.nodes[0].disconnect_p2ps() # Wait until all connections are closed wait_until(lambda: len(self.nodes[0].getpeerinfo()) == 0) |