aboutsummaryrefslogtreecommitdiff
path: root/test/functional/feature_pruning.py
diff options
context:
space:
mode:
authorLuke Dashjr <luke-jr+git@utopios.org>2022-03-21 18:38:54 +0000
committerLuke Dashjr <luke-jr+git@utopios.org>2022-06-03 07:20:07 +0000
commite593ae07c4fb41a26c95dbd03301607fc5b4d5e2 (patch)
tree22cb7df25420cb6ba7e6b97cfc45414611250dcf /test/functional/feature_pruning.py
parent2cf8c2caea90d9a3c314ba5f88bb76b3b5273d62 (diff)
downloadbitcoin-e593ae07c4fb41a26c95dbd03301607fc5b4d5e2.tar.xz
Bugfix: RPC/blockchain: pruneblockchain: Return the height of the actual last pruned block
From 0.14 (2017 Mar) until before 0.19 (2019 Nov), the height of the last block pruned was returned, subject to a bug if there were blocks left unpruned due to sharing files with later blocks. In #15991, this was "fixed" to the current implementation, introducing a new bug: now, it returns the first *unpruned* block. Since the user provides the parameter as a block to include in pruning, it makes more sense to fix the behaviour to match the documentation.
Diffstat (limited to 'test/functional/feature_pruning.py')
-rwxr-xr-xtest/functional/feature_pruning.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/feature_pruning.py b/test/functional/feature_pruning.py
index 77524e85a3..7dbeccbc09 100755
--- a/test/functional/feature_pruning.py
+++ b/test/functional/feature_pruning.py
@@ -291,7 +291,7 @@ class PruneTest(BitcoinTestFramework):
def prune(index):
ret = node.pruneblockchain(height=height(index))
- assert_equal(ret, node.getblockchaininfo()['pruneheight'])
+ assert_equal(ret + 1, node.getblockchaininfo()['pruneheight'])
def has_block(index):
return os.path.isfile(os.path.join(self.nodes[node_number].datadir, self.chain, "blocks", f"blk{index:05}.dat"))