diff options
| author | Ava Chow <github@achow101.com> | 2024-06-11 15:55:18 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-06-11 15:55:18 -0400 |
| commit | 1bcc91a52c61c4235766f71a21383d00b8f4955e (patch) | |
| tree | f3db3fd3e16115ffceaa2ab7db3615be0b4d044d /test/functional/feature_discover.py | |
| parent | 2251460f3efc68af9891505757280b773db68a09 (diff) | |
| parent | 24bc46c83b39149f4845a575a82337eb46d91bdb (diff) | |
| download | bitcoin-1bcc91a52c61c4235766f71a21383d00b8f4955e.tar.xz | |
Merge bitcoin/bitcoin#29521: cli: Detect port errors in rpcconnect and rpcport
24bc46c83b39149f4845a575a82337eb46d91bdb cli: Add warning for duplicate port definition (tdb3)
e208fb5d3bea4c1fb750cb0028819635ecdeb415 cli: Sanitize ports in rpcconnect and rpcport (tdb3)
Pull request description:
Adds invalid port detection to bitcoin-cli for -rpcconnect and -rpcport.
In addition to detecting malformed/invalid ports (e.g. those outside of the 16-bit port range, not numbers, etc.), bitcoin-cli also now considers usage of port 0 to be invalid. bitcoin-cli previously considered port 0 to be valid and attempted to use it to reach bitcoind.
Functional tests were added for invalid port detection as well as port prioritization.
Additionally, a warning is provided when a port is specified in both -rpcconnect and -rpcport.
This PR is an alternate approach to PR #27820 (e.g. SplitHostPort is unmodified).
Considered an alternative to 127.0.0.1 being specified in functional tests, but at first glance, this might need an update to test_framework/util.py (e.g. rpc_url), which might be left to a future PR.
ACKs for top commit:
S3RK:
light code review ACK 24bc46c83b39149f4845a575a82337eb46d91bdb
achow101:
ACK 24bc46c83b39149f4845a575a82337eb46d91bdb
cbergqvist:
re ACK 24bc46c83b39149f4845a575a82337eb46d91bdb
Tree-SHA512: c83ab6a30a08dd1ac8b368a7dcc2b4f23170f0b61dd67ffcad7bcda05096d333bcb9821fba11018151f55b2929c0a333bfec15b8bb863d83f41fc1974c6efca5
Diffstat (limited to 'test/functional/feature_discover.py')
0 files changed, 0 insertions, 0 deletions