diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-04-15 07:30:23 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-04-15 07:30:39 -0400 |
| commit | 18f11fb24b47c6762e659b4bd3413f03e2c9ec99 (patch) | |
| tree | 2733bd23c21318c3609690b846b85ce1b386287e /test/functional/create_cache.py | |
| parent | e831f18b1ed3b9749566145ceba6038f89c0a749 (diff) | |
| parent | 1b04302e43c91cf2353c545e646e50a672eab300 (diff) | |
Merge #18646: gui: use PACKAGE_NAME in exception message
1b04302e43c91cf2353c545e646e50a672eab300 gui: use PACKAGE_NAME in exception message (fanquake)
Pull request description:
Should address [this comment](https://github.com/bitcoin/bitcoin/issues/18643#issuecomment-613761345).
Can be triggered with a diff like:
```diff
diff --git a/src/qt/modaloverlay.cpp b/src/qt/modaloverlay.cpp
index 6243a71c7..e5d499012 100644
--- a/src/qt/modaloverlay.cpp
+++ b/src/qt/modaloverlay.cpp
@@ -6,6 +6,7 @@
#include <qt/forms/ui_modaloverlay.h>
#include <qt/guiutil.h>
+#include <util/check.h>
#include <chainparams.h>
@@ -179,6 +180,7 @@ void ModalOverlay::showHide(bool hide, bool userRequested)
void ModalOverlay::closeClicked()
{
+ CHECK_NONFATAL(false);
showHide(true);
userClosed = true;
}
```
and clicking close in the modal.
```bash
EXCEPTION: 18NonFatalCheckError
qt/modaloverlay.cpp:183 (closeClicked)
Internal bug detected: 'false'
You may report this issue here: https://github.com/bitcoin/bitcoin/issues
```
ACKs for top commit:
jonasschnelli:
Thanks. utACK 1b04302e43c91cf2353c545e646e50a672eab300
emilengler:
utACK 1b04302
hebasto:
ACK 1b04302e43c91cf2353c545e646e50a672eab300.
Tree-SHA512: 20118269882fbbb5602dafe8101c6ca6c92d7b97efc1ef280a68a83c6a58340018d05f837ecabefee618dc11a62e82828d5ecde4350a71a4c2fd24257b90d45c
Diffstat (limited to 'test/functional/create_cache.py')
0 files changed, 0 insertions, 0 deletions