diff options
| author | Ryan Ofsky <ryan@ofsky.org> | 2024-09-10 12:40:37 -0400 |
|---|---|---|
| committer | Ryan Ofsky <ryan@ofsky.org> | 2024-09-10 13:19:01 -0400 |
| commit | 2756797ecaf07b1a39645282e879bc70890e3f0b (patch) | |
| tree | 92df936d8e8643757426c3fd07c5c2086fe2e6d1 /test/CMakeLists.txt | |
| parent | e4fb97a5127ee767af7cbfab3ee07a18514bda1c (diff) | |
| parent | d4c7c4009da14c84576d43ab4a1241967cfa5ffc (diff) | |
Merge bitcoin/bitcoin#30065: init: fixes file descriptor accounting
d4c7c4009da14c84576d43ab4a1241967cfa5ffc init: error out if -maxconnections is negative (Sergi Delgado Segura)
c7736494813ad11e4ad53789104e70a19819f412 init: improves file descriptors accounting and docs (Sergi Delgado Segura)
29008a7ff43cf712a8438663e79cebdf698efae9 init: fixes fd accounting regarding poll/select (Sergi Delgado Segura)
Pull request description:
The current logic for file descriptor accounting is pretty convoluted and hard to follow. This is partially caused by the lack of documentation plus non-intuitive variable naming (which was more intuitive when fewer things were accounted for, but
hasn't aged well). This has led to this accounting being error-prone and hard to maintain (as shown in the first commit of this PR).
Redefine some of the constants, plus document what are we accounting for so this can be extended more easily
Fixes #18911
ACKs for top commit:
sr-gi:
> ACK [d4c7c40](https://github.com/bitcoin/bitcoin/commit/d4c7c4009da14c84576d43ab4a1241967cfa5ffc)
naumenkogs:
ACK d4c7c4009da14c84576d43ab4a1241967cfa5ffc
vasild:
ACK d4c7c4009da14c84576d43ab4a1241967cfa5ffc
TheCharlatan:
ACK d4c7c4009da14c84576d43ab4a1241967cfa5ffc
Tree-SHA512: 1524d10c8ad8f354f6ab9c244699adbcdae2dd7aba37de5b8f9e177c629e8a2cce0f6e8117e076dde3a592f5283bd30a4201db96a3c011e335c02d1fde7414bc
Diffstat (limited to 'test/CMakeLists.txt')
0 files changed, 0 insertions, 0 deletions