diff options
| author | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2023-02-03 18:57:14 +0000 |
|---|---|---|
| committer | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2023-02-03 19:03:46 +0000 |
| commit | daebf9ebb0c3e3b43e283b40480daecec86b7719 (patch) | |
| tree | 82e334f083339aa9ab6b0b41daccffcc7087d76c /src | |
| parent | aaa55971f6af3f19b22c28103630b856df266ebb (diff) | |
| parent | c497a198db6f417d2612078a9fbc101e259fab33 (diff) | |
Merge bitcoin-core/gui#705: doc: Fix comment about how wallet txs are sorted
c497a198db6f417d2612078a9fbc101e259fab33 Fix comment about how wallet txs are sorted (John Moffett)
Pull request description:
The wallet transactions in the node are not sorted by txid (or any hash) since https://github.com/bitcoin/bitcoin/pull/24699.
This is how they're stored in memory now:
https://github.com/bitcoin-core/gui/blob/835212cd1d8f8fc7f19775f5ff8cc21c099122b2/src/wallet/wallet.h#L397-L399
ACKs for top commit:
achow101:
ACK c497a198db6f417d2612078a9fbc101e259fab33
jarolrod:
ACK c497a198db6f417d2612078a9fbc101e259fab33
Tree-SHA512: e72559991688452ef254474d4235dc75fac655bce04909c3a0eece907360f4c6f57707db9b4373a4bd2271b23c57e863684c33e0728adf48e477c5499cdfdad7
Diffstat (limited to 'src')
| -rw-r--r-- | src/qt/transactiontablemodel.cpp | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/qt/transactiontablemodel.cpp b/src/qt/transactiontablemodel.cpp index 3b32137bd4..25d54bdce6 100644 --- a/src/qt/transactiontablemodel.cpp +++ b/src/qt/transactiontablemodel.cpp @@ -93,10 +93,7 @@ public: TransactionTableModel *parent; - /* Local cache of wallet. - * As it is in the same order as the CWallet, by definition - * this is sorted by sha256. - */ + //! Local cache of wallet sorted by transaction hash QList<TransactionRecord> cachedWallet; /** True when model finishes loading all wallet transactions on start */ |