diff options
author | John Newbery <john@johnnewbery.com> | 2017-02-09 15:48:39 -0500 |
---|---|---|
committer | John Newbery <john@johnnewbery.com> | 2017-03-07 16:45:09 -0500 |
commit | dab804c18a427901684ebe936b2069a97e04a268 (patch) | |
tree | 66c7c787b90e18241aa37b92087c2a834afb802e /src | |
parent | a012087667edb35a36f25ae06b42b1644d80e649 (diff) | |
download | bitcoin-dab804c18a427901684ebe936b2069a97e04a268.tar.xz |
Return correct error codes in fundrawtransaction().
The fundrawtransaction() RPC was returning misleading or incorrect error
codes (for example RPC_INTERNAL_ERROR when funding the transaction
failed). This commit fixes those error codes:
- RPC_INTERNAL_ERROR should not be returned for application-level
errors, only for genuine internal errors such as corrupted data.
That error code has been replaced with RPC_WALLET_ERROR.
This commit also updates the test cases to explicitly test the error code.
Diffstat (limited to 'src')
-rw-r--r-- | src/wallet/rpcwallet.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp index ea6795aeaa..90dd3a0b2a 100644 --- a/src/wallet/rpcwallet.cpp +++ b/src/wallet/rpcwallet.cpp @@ -2761,7 +2761,7 @@ UniValue fundrawtransaction(const JSONRPCRequest& request) string strFailReason; if (!pwallet->FundTransaction(tx, nFeeOut, overrideEstimatedFeerate, feeRate, changePosition, strFailReason, includeWatching, lockUnspents, setSubtractFeeFromOutputs, reserveChangeKey, changeAddress)) { - throw JSONRPCError(RPC_INTERNAL_ERROR, strFailReason); + throw JSONRPCError(RPC_WALLET_ERROR, strFailReason); } UniValue result(UniValue::VOBJ); |