diff options
| author | glozow <gloriajzhao@gmail.com> | 2023-06-02 14:21:15 +0100 |
|---|---|---|
| committer | glozow <gloriajzhao@gmail.com> | 2023-06-02 14:21:52 +0100 |
| commit | b22408df162a224d94ac54e8443b57ef3fd2ca72 (patch) | |
| tree | 8bee034cab7880dd5ddada95d93dc95e97250ddc /src | |
| parent | 6a560aceb75e618f3106a8850e053cd8de87616a (diff) | |
| parent | a7b46a1feae60e38fe4bdcacf5034f44cae49222 (diff) | |
| download | bitcoin-b22408df162a224d94ac54e8443b57ef3fd2ca72.tar.xz | |
Merge bitcoin/bitcoin#27603: test: added coverage to mining_basic.py
a7b46a1feae60e38fe4bdcacf5034f44cae49222 test: added coverage to mining_basic.py (kevkevin)
Pull request description:
Included a test that checks if we call submitblock with block.vtx.empty() then it throws an rpc deserialization error, currently we only test if !block.vtx->IsCoinBase() throws an rpc deserialization error
I've tested to make sure this actually doing what I intended by breaking up this if block into two if blocks with different error messages and running the functional test
https://github.com/bitcoin/bitcoin/blob/322ec63b01499c1ec52d3912ee382ebd59f2366b/src/rpc/mining.cpp#L963
This change should increase the test coverage for the `submitblock()` rpc in `./src/rpc/mining.cpp`
ACKs for top commit:
theStack:
ACK a7b46a1feae60e38fe4bdcacf5034f44cae49222
Tree-SHA512: 4078cb1fa879cc9e34438319f73085b521b90a5a95348b23e494cf8e5ac792ec426bc0e1a63e949645e16afebe54c5f35a194f02e20b7273871163d89a5c44e6
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions