diff options
| author | Ryan Ofsky <ryan@ofsky.org> | 2019-04-29 15:29:00 -0400 |
|---|---|---|
| committer | Ryan Ofsky <ryan@ofsky.org> | 2022-05-19 11:32:56 -0400 |
| commit | 77fabffef4ea840ee15c97061048fe8443d74658 (patch) | |
| tree | 89c0dfaf731dd6cc537f7dd138955727a41210fa /src | |
| parent | 0e55bc6e7fe439404dc56093a0949395dae51e6b (diff) | |
init: Remove Shutdown() node.args reset
This commit removes the `node.args = nullptr` assignment in the Shutdown()
function.
Clearing node.args there never made sense because it made the
Shutdown() function not idempotent, making it fragile and causing issues like
https://github.com/bitcoin/bitcoin/issues/23186.
The assignment also causes segfaults in GUI unit tests when a new
node().initParameterInteraction() call is added in OptionsModel to apply to Qt
settings (happens because AppTests calls Shutdown() which sets node.args to
null, and OptionTests runs after AppTests and then needs node.args not to be
null.)
Diffstat (limited to 'src')
| -rw-r--r-- | src/init.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/init.cpp b/src/init.cpp index f06b5bd0d0..c9e05026cf 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -320,7 +320,6 @@ void Shutdown(NodeContext& node) LogPrintf("%s: Unable to remove PID file: %s\n", __func__, fsbridge::get_filesystem_error_message(e)); } - node.args = nullptr; LogPrintf("%s: done\n", __func__); } |