diff options
| author | fanquake <fanquake@gmail.com> | 2023-07-18 10:10:25 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-07-18 10:24:13 +0100 |
| commit | 673acab223c0f896767b1ae784659df9f95452ae (patch) | |
| tree | e3ab67f9bbe01a96efe6f05e615e33ad78fd999b /src | |
| parent | bc88f3ab903f8a748a7570a6e17579dc4e9ba791 (diff) | |
| parent | 047daad4f59942488163c6be8516a69291646294 (diff) | |
Merge bitcoin/bitcoin#28090: validation: use noexcept instead of deprecated throw()
047daad4f59942488163c6be8516a69291646294 clang-tidy: turn on modernize-use-noexcept (fanquake)
85e9e1f80236b7f3768bb69415ad35c80460e120 validation: use noexcept instead of deprecated throw() (fanquake)
Pull request description:
We fixed this once before in https://github.com/bitcoin/bitcoin/pull/10965.
Turn on https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-noexcept.html#modernize-use-noexcept.
ACKs for top commit:
MarcoFalke:
lgtm ACK 047daad4f59942488163c6be8516a69291646294
sipa:
utACK 047daad4f59942488163c6be8516a69291646294
Empact:
utACK https://github.com/bitcoin/bitcoin/commit/047daad4f59942488163c6be8516a69291646294
stickies-v:
ACK 047daad4f59942488163c6be8516a69291646294
Tree-SHA512: 949b0fe598d66583747853094db13f196b402000e601f8634e5a708b55454d29c5aa18eaf1f2420d3ccf10e3e524b7414ff3a6fe4cb431420bf749c22b2b8bab
Diffstat (limited to 'src')
| -rw-r--r-- | src/.clang-tidy | 1 | ||||
| -rw-r--r-- | src/validation.cpp | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/.clang-tidy b/src/.clang-tidy index 39566c0cb7..84c9d5fb3a 100644 --- a/src/.clang-tidy +++ b/src/.clang-tidy @@ -4,6 +4,7 @@ bugprone-argument-comment, bugprone-use-after-move, misc-unused-using-decls, modernize-use-default-member-init, +modernize-use-noexcept, modernize-use-nullptr, performance-*, -performance-inefficient-string-concatenation, diff --git a/src/validation.cpp b/src/validation.cpp index 5bf8bd70e2..e6def01db5 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -5161,7 +5161,7 @@ static void FlushSnapshotToDisk(CCoinsViewCache& coins_cache, bool snapshot_load struct StopHashingException : public std::exception { - const char* what() const throw() override + const char* what() const noexcept override { return "ComputeUTXOStats interrupted."; } |