diff options
| author | fanquake <fanquake@gmail.com> | 2023-05-10 11:40:03 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-05-10 11:55:29 +0100 |
| commit | 883766fa4517d310839c8968994d1fb4effdc7c2 (patch) | |
| tree | bbd35b41ba66bd85e4000203fd5a424c39f3a5d4 /src/zmq | |
| parent | 3777c75d147954b24f770dc7781b27870eadf775 (diff) | |
| parent | fa1dbd04cab8039440e721eddabb760a40ba8c61 (diff) | |
| download | bitcoin-883766fa4517d310839c8968994d1fb4effdc7c2.tar.xz | |
Merge bitcoin/bitcoin#27573: ci: Remove CI_EXEC bloat in test/06_script_b.sh
fa1dbd04cab8039440e721eddabb760a40ba8c61 ci: Remove CI_EXEC bloat in test/06_script_b.sh (MarcoFalke)
fae8de926abaa9d7e5f0769865ded9491a72f866 ci: Move CI container kill out of 06_script_b.sh (MarcoFalke)
fa7d75540ed266d76c946d7ab8fdf4aa2d12f40e ci: Pass full env to CI pod to avoid missing a var (MarcoFalke)
Pull request description:
`CI_EXEC` has many issues:
* It is roughly equivalent to `bash -c "$*"`, meaning that the full command will be treated as a single string, ignoring tokens.
* It must be put in front of (almost) every command, making it easy to forget, hard to debug the resulting failure, and the code verbose.
Fix all issues in one script by removing it.
ACKs for top commit:
fanquake:
ACK fa1dbd04cab8039440e721eddabb760a40ba8c61 - this conflicts with #27125, but that is going to be rebased soon, and this could be merged in the interim. cc TheCharlatan
TheCharlatan:
ACK fa1dbd04cab8039440e721eddabb760a40ba8c61
Tree-SHA512: e5ab5503a05a787f2bc6ca25e71ad3dc166aade57e25d9677e72b1ca4e5fb6045c058dfd55f47ac93f710538e62d57c12cd7eb9d1260c6f55f3c8091908dc70d
Diffstat (limited to 'src/zmq')
0 files changed, 0 insertions, 0 deletions