diff options
| author | merge-script <fanquake@gmail.com> | 2024-05-16 11:18:26 +0800 |
|---|---|---|
| committer | merge-script <fanquake@gmail.com> | 2024-05-16 11:18:26 +0800 |
| commit | dd42a5ddea6a72e1e9cad54f8352c76b0b701973 (patch) | |
| tree | 3cc2d07889f7d4534773f75a4b8243e1bd574ee0 /src/wallet | |
| parent | ae2658caacc1f3d8ab48d6b8ece481b1e9707fbb (diff) | |
| parent | d0b047494c28381942c09d0cca45baa323bfcffc (diff) | |
| download | bitcoin-dd42a5ddea6a72e1e9cad54f8352c76b0b701973.tar.xz | |
Merge bitcoin/bitcoin#30085: p2p: detect addnode cjdns peers in GetAddedNodeInfo()
d0b047494c28381942c09d0cca45baa323bfcffc test: add GetAddedNodeInfo() CJDNS regression unit test (Jon Atack)
684da9707040ce25d95b2954eda50b811136d92c p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo() (Jon Atack)
Pull request description:
Addnode peers connected to us via the cjdns network are currently not detected by `CConnman::GetAddedNodeInfo()`, i.e. `fConnected` is always false. This causes the following issues:
- RPC `getaddednodeinfo` incorrectly shows them as not connected
- `CConnman::ThreadOpenAddedConnections()` continually retries to connect them
Fix the issue and add a unit regression test. Extracted from #28248. Suggest running the test with:
`./src/test/test_bitcoin -t net_peer_connection_tests -l test_suite`
ACKs for top commit:
mzumsande:
utACK d0b047494c28381942c09d0cca45baa323bfcffc
brunoerg:
crACK d0b047494c28381942c09d0cca45baa323bfcffc
pinheadmz:
ACK d0b047494c28381942c09d0cca45baa323bfcffc
Tree-SHA512: a4d81425f79558f5792585611f3fe8ab999b82144daeed5c3ec619861c69add934c2b2afdad24c8488a0ade94f5ce8112f5555d60a1ce913d4f5a1cf5dbba55a
Diffstat (limited to 'src/wallet')
0 files changed, 0 insertions, 0 deletions