diff options
| author | furszy <matiasfurszyfer@protonmail.com> | 2023-07-16 13:31:38 -0300 |
|---|---|---|
| committer | furszy <matiasfurszyfer@protonmail.com> | 2024-02-09 14:54:50 -0300 |
| commit | 83b762845f5804f23b63526d403b2f327fe99632 (patch) | |
| tree | 73b81732c18231ddcf7bd550b43d38b6c4b6c055 /src/wallet/walletdb.h | |
| parent | 595d50a1032ad7ffa9945464c86aa57f16665e93 (diff) | |
| download | bitcoin-83b762845f5804f23b63526d403b2f327fe99632.tar.xz | |
wallet: batch and simplify ZapSelectTx process
The goal of the function is to erase the wallet transactions that
match the inputted hashes. There is no need to traverse the database,
reading record by record, to then perform single entry removals for
each of them.
To ensure consistency and improve performance, this change-set removes
all tx records within a single atomic db batch operation, as well as
it cleans up code, improves error handling and simplifies the
transactions removal process entirely.
This optimizes the removal of watch-only transactions during the wallet
migration process and the 'removeprunedfunds' RPC command.
Diffstat (limited to 'src/wallet/walletdb.h')
| -rw-r--r-- | src/wallet/walletdb.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/wallet/walletdb.h b/src/wallet/walletdb.h index dad0b18a78..62449eb64e 100644 --- a/src/wallet/walletdb.h +++ b/src/wallet/walletdb.h @@ -275,8 +275,6 @@ public: bool EraseActiveScriptPubKeyMan(uint8_t type, bool internal); DBErrors LoadWallet(CWallet* pwallet); - DBErrors FindWalletTxHashes(std::vector<uint256>& tx_hashes); - DBErrors ZapSelectTx(std::vector<uint256>& vHashIn, std::vector<uint256>& vHashOut); //! write the hdchain model (external chain child index counter) bool WriteHDChain(const CHDChain& chain); |