diff options
| author | John Newbery <john@johnnewbery.com> | 2019-04-03 17:55:24 -0400 |
|---|---|---|
| committer | John Newbery <john@johnnewbery.com> | 2019-10-18 09:26:32 -0400 |
| commit | d1734f9a3b138ab046f38ee44a09bc3847bf938a (patch) | |
| tree | 172eb76ab4c70e926fe292d8e535cae48ee879fc /src/wallet/wallet.h | |
| parent | b6f486a02b463ffeaf82ec11fc6f74f439c037ae (diff) | |
| download | bitcoin-d1734f9a3b138ab046f38ee44a09bc3847bf938a.tar.xz | |
[wallet] Remove return value from CommitTransaction()
CommitTransaction returns a bool to indicate success, but since commit
b3a74100b8 it only returns true, even if the transaction was not
successfully broadcast. This commit changes CommitTransaction() to return
void.
All dead code in `if (!CommitTransaction())` branches has been removed.
Diffstat (limited to 'src/wallet/wallet.h')
| -rw-r--r-- | src/wallet/wallet.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h index d12c6077bf..8113e60aa6 100644 --- a/src/wallet/wallet.h +++ b/src/wallet/wallet.h @@ -1157,7 +1157,7 @@ public: * @param orderForm[in] BIP 70 / BIP 21 order form details to be set on the transaction. * @param state[in,out] CValidationState object returning information about whether the transaction was accepted */ - bool CommitTransaction(CTransactionRef tx, mapValue_t mapValue, std::vector<std::pair<std::string, std::string>> orderForm, CValidationState& state); + void CommitTransaction(CTransactionRef tx, mapValue_t mapValue, std::vector<std::pair<std::string, std::string>> orderForm, CValidationState& state); bool DummySignTx(CMutableTransaction &txNew, const std::set<CTxOut> &txouts, bool use_max_sig = false) const { |