diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-12-09 17:54:15 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-12-09 17:54:21 +0100 |
| commit | 2f26d8ec703c1cfdc0d883501d7b327335e1b602 (patch) | |
| tree | a54961c638857fa1d051acab25c0429eb302fb7e /src/wallet/wallet.cpp | |
| parent | c840ab0231bc29057172179f005001c9ab299554 (diff) | |
| parent | 61fb410c0d9bc9e5fe4e3c52b4c519d49faf15f6 (diff) | |
Merge bitcoin/bitcoin#23725: test: fix `feature_coinstatsindex.py --descriptors` and add to test runner
61fb410c0d9bc9e5fe4e3c52b4c519d49faf15f6 test: add feature_coinstatsindex.py --descriptors to test_runner.py (Sebastian Falbesoner)
50b044a88e3cfa67e28261333e658f4288d54018 test: fix test feature_coinstatsindex.py for descriptor wallets (Sebastian Falbesoner)
Pull request description:
The functional test feature_coinstatsindex.py currently fails on master branch, if descriptor wallets are used (argument `--descriptors`; or if BDB is not compiled, see https://github.com/bitcoin/bitcoin/pull/23682#issuecomment-989827592). This is due to the fact that different change output types are used for created transactions (P2WPKH for legacy wallets, P2TR for descriptor wallets; the former doesn't have a ScriptPubKeyMan for bech32m), resulting in different tx sizes and hence also fees. Fix this by explicitely setting the output type via passing both `-addresstype=bech32` and `-changetype=bech32` as argument. The former would not be needed by now, but makes the test more deterministic and avoids a failure if bech32m becomes the default address type.
Should further pave the way for #23682.
ACKs for top commit:
MarcoFalke:
cr ACK 61fb410c0d9bc9e5fe4e3c52b4c519d49faf15f6
Tree-SHA512: 300a53f539c0b874da5fc1dd1e4e41b9408dc5526c5858c79f0aabf2ab07e57df4c9cc627fafe25246206752754a91a2977a3df8f8b2d98fb98e51c7e4d81633
Diffstat (limited to 'src/wallet/wallet.cpp')
0 files changed, 0 insertions, 0 deletions