diff options
| author | Ava Chow <github@achow101.com> | 2024-09-20 14:35:05 -0400 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-09-20 14:35:05 -0400 |
| commit | 0894748316c5483063ceb6c3cd76d32febac35e9 (patch) | |
| tree | 8f07055645ed03f5aa123da9dd3f2478e4578ad5 /src/wallet/test/ismine_tests.cpp | |
| parent | f57a6754ed6a9b0d11e03189aa808d8376ce51b6 (diff) | |
| parent | 284bd17309ab3b124d9dcddfec62f5506383343b (diff) | |
Merge bitcoin/bitcoin#30918: fuzz: Add check in `p2p_headers_presync` that chain work never exceeds minimum work
284bd17309ab3b124d9dcddfec62f5506383343b add check that chainwork doesn't exceed minimum work (marcofleon)
9aa5d1c3fcd10ecb94310ad515a8569bc2d418f8 add clarification in comment (marcofleon)
Pull request description:
A followup to https://github.com/bitcoin/bitcoin/pull/30661
The added assertion just makes sure that the fuzz test is working as intended. If we're sure that the total work of the test chain is never more than minimum chain work, then we can be sure that the later assertion failure would actually mean that a bug in the headers presync logic was found.
This PR also addresses:
https://github.com/bitcoin/bitcoin/pull/30661#discussion_r1746614616
https://github.com/bitcoin/bitcoin/pull/30661#discussion_r1764943665
https://github.com/bitcoin/bitcoin/pull/30661#discussion_r1764961991
ACKs for top commit:
instagibbs:
reACK 284bd17309ab3b124d9dcddfec62f5506383343b
maflcko:
review ACK 284bd17309ab3b124d9dcddfec62f5506383343b
achow101:
ACK 284bd17309ab3b124d9dcddfec62f5506383343b
Tree-SHA512: 76a9dffea4b6e13499c636d6ad26af06135319d25117c0eb40cf8dfcfdca6a4549c9b4d2ba835192ca355e0f8d476227aeabf8bdb68770def72a9fb521533fe5
Diffstat (limited to 'src/wallet/test/ismine_tests.cpp')
0 files changed, 0 insertions, 0 deletions