diff options
| author | furszy <matiasfurszyfer@protonmail.com> | 2022-12-06 12:39:00 -0300 |
|---|---|---|
| committer | furszy <matiasfurszyfer@protonmail.com> | 2023-04-03 17:23:42 -0300 |
| commit | dc1cc1c35995dc09085b3d9270c445b7923fdb51 (patch) | |
| tree | 08e07a0b545fff6de076eba22a56a0dbddc747c0 /src/wallet/spend.h | |
| parent | 5150e280103dd41c8a438ce72359b0f25ff23a2f (diff) | |
| download | bitcoin-dc1cc1c35995dc09085b3d9270c445b7923fdb51.tar.xz | |
gui: bugfix, getAvailableBalance skips selected coins
The previous behavior for getAvailableBalance when coin control
has selected coins was to return the sum of them. Instead, we
are currently returning the wallet's available total balance minus
the selected coins total amount.
This turns into a GUI-only issue for the "use available balance"
button when the user manually select coins in the send screen.
Reason:
We missed to update the GetAvailableBalance function to include
the coin control selected coins on #25685.
Context:
Since #25685 we skip the selected coins inside `AvailableCoins`,
the reason is that there is no need to traverse the wallet's
txes map just to get coins that can directly be fetched by
their id.
Diffstat (limited to 'src/wallet/spend.h')
| -rw-r--r-- | src/wallet/spend.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/wallet/spend.h b/src/wallet/spend.h index 78c2c5f22b..cc9ccf3011 100644 --- a/src/wallet/spend.h +++ b/src/wallet/spend.h @@ -94,8 +94,6 @@ CoinsResult AvailableCoins(const CWallet& wallet, */ CoinsResult AvailableCoinsListUnspent(const CWallet& wallet, const CCoinControl* coinControl = nullptr, CoinFilterParams params = {}) EXCLUSIVE_LOCKS_REQUIRED(wallet.cs_wallet); -CAmount GetAvailableBalance(const CWallet& wallet, const CCoinControl* coinControl = nullptr); - /** * Find non-change parent output. */ |