diff options
| author | Ryan Ofsky <ryan@ofsky.org> | 2024-04-04 09:25:12 -0400 |
|---|---|---|
| committer | Ryan Ofsky <ryan@ofsky.org> | 2024-04-04 09:25:16 -0400 |
| commit | 5a5ab1d5446693ee2655860c2f2920bcc3389c83 (patch) | |
| tree | 1319a9c3a4c82f93a1783a83c90645b7a8c21217 /src/wallet/spend.cpp | |
| parent | 71c51c161d476cc495afdb7864283fdb84d2dc0c (diff) | |
| parent | bbe82c116e72ca0638751e063bf564cd1fe5c4d5 (diff) | |
| download | bitcoin-5a5ab1d5446693ee2655860c2f2920bcc3389c83.tar.xz | |
Merge bitcoin/bitcoin#29776: ThreadSanitizer: Fix #29767
bbe82c116e72ca0638751e063bf564cd1fe5c4d5 Fix #29767, set m_synced = true after Commit() (nanlour)
Pull request description:
I think this problem https://github.com/bitcoin/bitcoin/issues/29767#issue-2216373048 is because of
in BaseIndex::Sync
https://github.com/bitcoin/bitcoin/blob/61de64df6790077857faba84796bb874b59c5d15/src/index/base.cpp#L163-L168
Setup m_synced = true; before Commit();
So this may cause a race condition window to BaseIndex::BlockConnected
https://github.com/bitcoin/bitcoin/blob/61de64df6790077857faba84796bb874b59c5d15/src/index/base.cpp#L271-L274
So i try to fix it with move m_synced = true after Commit().
Also see comment of Sync():
https://github.com/bitcoin/bitcoin/blob/61de64df6790077857faba84796bb874b59c5d15/src/index/base.h#L151-L156
I am a newcomer interested in Bitcoin, trying to become a member of the Bitcoin Core development team. Please give me some feedback if you could, as I may be doing something wrong. Thank you!
ACKs for top commit:
fjahr:
Code review ACK bbe82c116e72ca0638751e063bf564cd1fe5c4d5
ryanofsky:
Code review ACK bbe82c116e72ca0638751e063bf564cd1fe5c4d5
Tree-SHA512: 89a09498a232c87ef1e083d4cc4ed9bb15f045ad0624d5d150a87187b2b8a48a41137974dbc7ea5c37f73da90742c43259f5aa7f84b4179eb8d62033e44fa479
Diffstat (limited to 'src/wallet/spend.cpp')
0 files changed, 0 insertions, 0 deletions