diff options
author | MarcoFalke <falke.marco@gmail.com> | 2020-08-07 08:05:38 +0200 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2020-08-07 08:07:37 +0200 |
commit | 4b705b1c98f60ab736df98d62a8d4988f61678d5 (patch) | |
tree | bae65e2ddadaf6e101170e8dcb3177c228325899 /src/wallet/rpcwallet.cpp | |
parent | 6d8543504d8c5bde1d12a3c60407dee44d2c8e11 (diff) | |
parent | edc316020e8270dafc5e31465d532baebdafd3dd (diff) | |
download | bitcoin-4b705b1c98f60ab736df98d62a8d4988f61678d5.tar.xz |
Merge #19098: test: Remove duplicate NodeContext hacks
edc316020e8270dafc5e31465d532baebdafd3dd test: Remove duplicate NodeContext hacks (Russell Yanofsky)
Pull request description:
Qt tests currently are currently using two NodeContext structs at the same time, one in interfaces::NodeImpl::m_context, and the other in BasicTestingSetup::m_node, and the tests have hacks transferring state between them.
Fix this by getting rid of the NodeImpl::m_context struct and making it a pointer. This way a common BitcoinApplication object can be used for all qt tests, but they can still have their own testing setups.
Non-test code is changing but non-test behavior is still the same as before.
Motivation for this PR is to be able to remove the "std::move(test.m_node.connman)" and mempool hacks for swapping individual NodeContext members in Qt tests, because followup PR #19099 adds yet another member (wallet_client) that needs to be swapped. After this change, the whole NodeContext struct can be swapped instead of individual members, so the workarounds are less fragile and invasive.
ACKs for top commit:
MarcoFalke:
crACK edc316020e8270dafc5e31465d532baebdafd3dd 🌮
promag:
ACK edc316020e8270dafc5e31465d532baebdafd3dd.
Tree-SHA512: c1650e4127f43a4020304ca7c13b5d9122fb5723aacd8fa1cf855d03c6052fcfb7685810aa2a5ef708561015f0022fecaacbad479295104ca45d2c17579466a4
Diffstat (limited to 'src/wallet/rpcwallet.cpp')
0 files changed, 0 insertions, 0 deletions