diff options
| author | fanquake <fanquake@gmail.com> | 2024-01-05 10:37:42 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2024-01-05 10:42:10 +0000 |
| commit | 143ace65db3943845125068d48feeb1168dfcb88 (patch) | |
| tree | 695ce418811dc596f1c4d1e03e01d19433f51b06 /src/wallet/rpc | |
| parent | d44554567f2726e572027a146516d87e4dcea2f5 (diff) | |
| parent | fa46cc22bc696e6845915ae91d6b68e36bf4c242 (diff) | |
| download | bitcoin-143ace65db3943845125068d48feeb1168dfcb88.tar.xz | |
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion
fa46cc22bc696e6845915ae91d6b68e36bf4c242 Remove deprecated -rpcserialversion (MarcoFalke)
Pull request description:
The flag is problematic for many reasons:
* It is deprecated
* It is a global flag, requiring a restart to change, as opposed to a flag that can be set on each RPC invocation
* It may be hidden in config files by accident, hard to debug, causing LND crashes and bugs, see https://github.com/bitcoin/bitcoin/issues/28730#issuecomment-1780940868
* It makes performance improvements harder to implement: https://github.com/bitcoin/bitcoin/pull/17529#issuecomment-556082818
Fix all issues by removing it.
If there is a use-case, likely a per-RPC flag can be added, if needed.
ACKs for top commit:
ajtowns:
crACK fa46cc22bc696e6845915ae91d6b68e36bf4c242
TheCharlatan:
lgtm ACK fa46cc22bc696e6845915ae91d6b68e36bf4c242
Tree-SHA512: 96ba1c60356ce93954fe5c2a59045771c6d1516ad0d9dc436ef1800a1f1b0153f0d5fb78ca99d53ad54ba25fbce36962bdf1d4325aceedfc8154a61347a6a915
Diffstat (limited to 'src/wallet/rpc')
| -rw-r--r-- | src/wallet/rpc/transactions.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/wallet/rpc/transactions.cpp b/src/wallet/rpc/transactions.cpp index cd7ed461f0..0e30d3e0fe 100644 --- a/src/wallet/rpc/transactions.cpp +++ b/src/wallet/rpc/transactions.cpp @@ -783,8 +783,7 @@ RPCHelpMan gettransaction() ListTransactions(*pwallet, wtx, 0, false, details, filter, /*filter_label=*/std::nullopt); entry.pushKV("details", details); - std::string strHex = EncodeHexTx(*wtx.tx, pwallet->chain().rpcSerializationWithoutWitness()); - entry.pushKV("hex", strHex); + entry.pushKV("hex", EncodeHexTx(*wtx.tx)); if (verbose) { UniValue decoded(UniValue::VOBJ); |